From 8aae17870a5ec2fdd9f0d4d61d33c792ff7b62b0 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 5 Jul 2026 18:09:25 +0900 Subject: fix(git-bitbucket-driver): match PHP exception/fallibility semantics for fallback paths VcsDriverInterface::get_source/get_dist were made fallible in the Rust port even though PHP's are infallible, forcing GitBitbucketDriver's fallback delegation to silently swallow errors via unwrap_or_default()/ok().flatten(). Make the trait infallible to match PHP, updating the mechanical Ok(...) wrapping in all implementors. Also narrow attempt_clone_fallback's cleanup to only trigger on RuntimeException, mirroring PHP's catch (\RuntimeException $e), using the same downcast pattern already used by has_composer_file for TransportException. --- crates/shirabe/src/repository/vcs/vcs_driver_interface.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/repository/vcs/vcs_driver_interface.rs') diff --git a/crates/shirabe/src/repository/vcs/vcs_driver_interface.rs b/crates/shirabe/src/repository/vcs/vcs_driver_interface.rs index 5d2be04..fb10d0f 100644 --- a/crates/shirabe/src/repository/vcs/vcs_driver_interface.rs +++ b/crates/shirabe/src/repository/vcs/vcs_driver_interface.rs @@ -29,9 +29,9 @@ pub trait VcsDriverInterface: std::fmt::Debug { fn get_tags(&mut self) -> anyhow::Result>; - fn get_dist(&self, identifier: &str) -> anyhow::Result>>; + fn get_dist(&self, identifier: &str) -> Option>; - fn get_source(&self, identifier: &str) -> anyhow::Result>; + fn get_source(&self, identifier: &str) -> IndexMap; fn get_url(&self) -> String; -- cgit v1.3.1