From 3d4a0cadc950d4440251efa11b55b0bfb0afdef7 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 6 Aug 2026 04:22:46 +0900 Subject: chore: drop @param/@return tags that only restate Rust types The ported docblocks copied @param and @return straight from the PHP source. When such a tag carries nothing but a type and an argument name, the Rust signature already states it, so the line is noise. Tags whose text adds prose beyond the type are kept. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs | 2 -- crates/shirabe/src/repository/vcs/github_driver.rs | 4 ---- crates/shirabe/src/repository/vcs/gitlab_driver.rs | 7 ------- 3 files changed, 13 deletions(-) (limited to 'crates/shirabe/src/repository/vcs') diff --git a/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs b/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs index 394077e9..87cf7c44 100644 --- a/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs +++ b/crates/shirabe/src/repository/vcs/git_bitbucket_driver.rs @@ -741,7 +741,6 @@ impl GitBitbucketDriver { /// @phpstan-impure /// - /// @return true /// @throws \RuntimeException fn attempt_clone_fallback(&mut self) -> anyhow::Result { match self.setup_fallback_driver(&self.generate_ssh_url()) { @@ -775,7 +774,6 @@ impl GitBitbucketDriver { Ok(()) } - /// @param array $cloneLinks fn parse_clone_urls(&mut self, clone_links: Option) { let list = match clone_links { Some(PhpMixed::List(l)) => l, diff --git a/crates/shirabe/src/repository/vcs/github_driver.rs b/crates/shirabe/src/repository/vcs/github_driver.rs index 8134a16b..c7b84e51 100644 --- a/crates/shirabe/src/repository/vcs/github_driver.rs +++ b/crates/shirabe/src/repository/vcs/github_driver.rs @@ -416,7 +416,6 @@ impl GitHubDriver { .unwrap_or(None)) } - /// @return array|false fn get_funding_info(&mut self) -> PhpMixed { if let Some(ref info) = self.funding_info { return info.clone(); @@ -996,8 +995,6 @@ impl GitHubDriver { } /// Gives back the loaded /repos// result - /// - /// @return mixed[]|null pub fn get_repo_data(&mut self) -> anyhow::Result>> { self.fetch_root_identifier()?; @@ -1234,7 +1231,6 @@ impl GitHubDriver { /// @phpstan-impure /// - /// @return true /// @throws \RuntimeException pub(crate) fn attempt_clone_fallback( &mut self, diff --git a/crates/shirabe/src/repository/vcs/gitlab_driver.rs b/crates/shirabe/src/repository/vcs/gitlab_driver.rs index 9a4c22a1..35d0b5ca 100644 --- a/crates/shirabe/src/repository/vcs/gitlab_driver.rs +++ b/crates/shirabe/src/repository/vcs/gitlab_driver.rs @@ -721,7 +721,6 @@ impl GitLabDriver { /// @phpstan-impure /// - /// @return true /// @throws \RuntimeException pub(crate) fn attempt_clone_fallback(&mut self) -> anyhow::Result { let url = if !self.is_private { @@ -1030,8 +1029,6 @@ impl GitLabDriver { } /// Gives back the loaded /projects// result - /// - /// @return mixed[]|null pub fn get_repo_data(&mut self) -> anyhow::Result>> { self.fetch_project()?; @@ -1061,10 +1058,6 @@ impl GitLabDriver { None } - /// @param array $configuredDomains - /// @param array $urlParts - /// - /// @return string|false fn determine_origin( configured_domains: &PhpMixed, guessed_domain: String, -- cgit v1.3.1