From 971824aa15334fd12d08ae0f441f6bf6079344c3 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 7 Jun 2026 10:33:53 +0900 Subject: feat(shirabe): resolve phase-b TODOs with shared ownership Replace TODO(phase-b) placeholders (todo!() and commented-out code) with real implementations: - Share JsonFile via Rc> so JsonConfigSource and the owning command can hold the same instance (base_config_command, config_command, repository_command, require_command, create_project, remove_command, factory) - Change InstallerInterface methods (is_installed, download, prepare, cleanup, get_install_path) to &mut self so initialize_vendor_dir can run, propagated to all installer implementations - Pass io/config/filesystem/process by clone instead of moving or stubbing (auth_helper, svn_driver, curl_downloader, library_installer) - Make TransportException Clone and store it by value in VcsRepository - Clone operations in Transaction sort, root_aliases/temporary_constraints in RepositorySet::create_pool, and share CompletePackage via handle in PlatformRepository - Wire up set_option, set_requires/set_dev_requires, installation manager setters, BumpCommand::set_composer, and clean_backups/set_local_phar --- crates/shirabe/src/repository/vcs/svn_driver.rs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/repository/vcs') diff --git a/crates/shirabe/src/repository/vcs/svn_driver.rs b/crates/shirabe/src/repository/vcs/svn_driver.rs index 3d344ec..9b2ea47 100644 --- a/crates/shirabe/src/repository/vcs/svn_driver.rs +++ b/crates/shirabe/src/repository/vcs/svn_driver.rs @@ -85,8 +85,7 @@ impl SvnDriver { } self.inner.cache = Some(Cache::new( - // TODO(phase-b): pass io by reference/clone - todo!("self.inner.io clone"), + self.inner.io.clone(), &format!( "{}/{}", self.inner @@ -551,10 +550,9 @@ impl SvnDriver { if self.util.is_none() { self.util = Some(SvnUtil::new( self.base_url.clone(), - // TODO(phase-b): clone or borrow io/config - todo!("self.inner.io clone"), - todo!("self.inner.config clone"), - Some(todo!("self.inner.process clone")), + self.inner.io.clone(), + self.inner.config.clone(), + Some(self.inner.process.clone()), )); self.util .as_mut() -- cgit v1.3.1