From 3a388b98a9aa6a14b1c7f7dc909c109cf9837800 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 16 Aug 2026 00:59:54 +0900 Subject: refactor: narrow pub(crate) items to private Porting mapped every PHP `protected` member onto `pub(crate)`, which is wider than nearly all of them need. Each item demoted here is reached only from the module that defines it, so the crate-wide visibility conveyed nothing. Every `pub(crate)` that survives has at least one reader in another module of the same crate. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/repository/vcs_repository.rs | 28 ++++++++++++------------- 1 file changed, 14 insertions(+), 14 deletions(-) (limited to 'crates/shirabe/src/repository/vcs_repository.rs') diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs index 4da3f0ad..4066ac44 100644 --- a/crates/shirabe/src/repository/vcs_repository.rs +++ b/crates/shirabe/src/repository/vcs_repository.rs @@ -37,36 +37,36 @@ use shirabe_semver::constraint::SimpleConstraint; // TODO(port): the driver registration should be refactored later. #[derive(Debug)] pub struct VcsRepository { - pub(crate) inner: ArrayRepository, + inner: ArrayRepository, /// @var string - pub(crate) url: String, + url: String, /// @var ?string /// /// Interior mutability: set lazily by the (now `&self`) `initialize`, mirroring how PHP's /// inherited ArrayRepository methods drive the overridden `initialize()` on first access. - pub(crate) package_name: std::cell::RefCell>, + package_name: std::cell::RefCell>, /// @var bool - pub(crate) is_verbose: bool, + is_verbose: bool, /// @var bool - pub(crate) is_very_verbose: bool, + is_very_verbose: bool, /// @var IOInterface - pub(crate) io: std::rc::Rc>, + io: std::rc::Rc>, /// @var Config - pub(crate) config: std::rc::Rc>, + config: std::rc::Rc>, /// @var VersionParser - pub(crate) version_parser: std::cell::RefCell>, + version_parser: std::cell::RefCell>, /// @var string - pub(crate) r#type: String, + r#type: String, /// @var ?LoaderInterface - pub(crate) loader: std::cell::RefCell>>, + loader: std::cell::RefCell>>, /// @var array - pub(crate) repo_config: IndexMap, + repo_config: IndexMap, /// @var HttpDownloader - pub(crate) http_downloader: std::rc::Rc>, + http_downloader: std::rc::Rc>, /// @var ProcessExecutor - pub(crate) process_executor: std::rc::Rc>, + process_executor: std::rc::Rc>, /// @var bool - pub(crate) branch_error_occurred: std::cell::Cell, + branch_error_occurred: std::cell::Cell, /// @var array> drivers: IndexMap, /// @var ?VcsDriverInterface -- cgit v1.3.1-4-g156e