From cd25c3e193f05a5e89bca2a1c706c85fdc9c9155 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 6 Jun 2026 02:13:59 +0900 Subject: refactor(repository): make read methods fallible and take &mut self Change RepositoryInterface and WritableRepositoryInterface read methods (find_package, find_packages, get_packages, load_packages, search, get_providers, get_canonical_packages) to take &mut self and return anyhow::Result, so lazy-loading repositories such as ComposerRepository can perform fallible I/O and mutate internal state on access. Update all implementors and call sites to propagate the Result and pass mutable references. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/repository/vcs_repository.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/repository/vcs_repository.rs') diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs index 7a570c6..9a39b76 100644 --- a/crates/shirabe/src/repository/vcs_repository.rs +++ b/crates/shirabe/src/repository/vcs_repository.rs @@ -520,7 +520,7 @@ impl VcsRepository { ) .into(), ), - ) { + )? { if is_very_verbose { self.io.write_error(&format!( "Skipped tag {}, it conflicts with an another tag ({}) as both resolve to {} internally", @@ -763,7 +763,7 @@ impl VcsRepository { .overwrite_error4("", false, None, io_interface::NORMAL); } - if self.inner.get_packages().is_empty() { + if self.inner.get_packages()?.is_empty() { return Err(InvalidRepositoryException::new(format!( "No valid composer.json was found in any branch or tag of {}, could not load a package from it.", self.url @@ -948,7 +948,7 @@ impl VcsRepository { SimpleConstraint::new("=".to_string(), version_normalized.to_string(), None) .into(), ), - ) { + )? { if is_very_verbose { self.io.write_error(&format!( "Skipped cached version {}, it conflicts with an another tag ({}) as both resolve to {} internally", -- cgit v1.3.1