From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/repository/path_repository.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/repository') diff --git a/crates/shirabe/src/repository/path_repository.rs b/crates/shirabe/src/repository/path_repository.rs index 17f22d40..25a5ad57 100644 --- a/crates/shirabe/src/repository/path_repository.rs +++ b/crates/shirabe/src/repository/path_repository.rs @@ -184,7 +184,11 @@ impl PathRepository { continue; } - let json = file_get_contents(&composer_file_path).unwrap_or_default(); + // TODO(bytes): JsonFile::parse_json takes the JSON as a &str. + let json = String::from_utf8_lossy( + &file_get_contents(&composer_file_path).unwrap_or_default(), + ) + .into_owned(); let parsed = JsonFile::parse_json(Some(&json), Some(&composer_file_path))?; let mut package: IndexMap = match parsed { PhpMixed::Array(m) => m.into_iter().collect(), -- cgit v1.3.1-4-g156e