From a9f19862350c6fd3592d93515d869ffe07ecb399 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 4 Jun 2026 21:08:22 +0900 Subject: feat: resolve trivial todo!() sites with existing constructors Replace todo!("VersionParser::new()") with VersionParser::new() at 6 call sites (array_loader, base_command, create_project_command, vcs_repository, http_downloader x2) and EventDispatcher::io_clone with self.io.clone(). All targets already exist on their types. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/repository/vcs_repository.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'crates/shirabe/src/repository') diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs index 804ba51..7a570c6 100644 --- a/crates/shirabe/src/repository/vcs_repository.rs +++ b/crates/shirabe/src/repository/vcs_repository.rs @@ -296,8 +296,7 @@ impl VcsRepository { } .into()); } - // TODO(phase-b): VersionParser has no public `new` - self.version_parser = Some(todo!("VersionParser::new()")); + self.version_parser = Some(VersionParser::new()); if self.loader.is_none() { self.loader = Some(Box::new(ArrayLoader::new( Some(todo!("phase-b: clone VersionParser")), -- cgit v1.3.1