From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/util/config_validator.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/util/config_validator.rs') diff --git a/crates/shirabe/src/util/config_validator.rs b/crates/shirabe/src/util/config_validator.rs index f8018fe5..93d3b4bb 100644 --- a/crates/shirabe/src/util/config_validator.rs +++ b/crates/shirabe/src/util/config_validator.rs @@ -72,7 +72,11 @@ impl ConfigValidator { } if manifest.is_some() { - let contents = shirabe_php_shim::file_get_contents(file).unwrap_or_default(); + // TODO(bytes): detect_duplicate_keys scans the JSON as a &str. + let contents = String::from_utf8_lossy( + &shirabe_php_shim::file_get_contents(file).unwrap_or_default(), + ) + .into_owned(); if let Some((key, line)) = detect_duplicate_keys(&contents) { warnings.push(format!("Key {key} is a duplicate in {file} at line {line}")); } -- cgit v1.3.1-4-g156e