From 91692846909ed191addb7ec1c34aad11392ab88b Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 18 Jul 2026 15:03:55 +0900
Subject: perf(regex): eliminate per-call clone overhead in preg_* dispatch

regex::Regex::clone() does not share the underlying meta engine's
search-cache pool, so every fresh clone pays a ~10us warmup cost on
its first use. Two changes together eliminate this across nearly all
preg_* call sites:

- A php_regex! macro resolves PHP-style patterns to a per-call-site
  &'static regex::Regex (via regex-macro's LazyLock), applied at the
  majority of call sites throughout the codebase.
- Call sites still passing dynamic pattern strings go through
  PATTERN_CACHE, which now stores Arc<(Regex, bool)> and hands out
  Arc::clone()s instead of cloning the Regex itself.

PregPattern::resolve() returns a ResolvedPattern enum (Arc or
'static reference) rather than an owned Regex, so neither path ever
clones the Regex proper.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---
 crates/shirabe/src/util/config_validator.rs | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

(limited to 'crates/shirabe/src/util/config_validator.rs')

diff --git a/crates/shirabe/src/util/config_validator.rs b/crates/shirabe/src/util/config_validator.rs
index 4137a2d9..a9b89fd6 100644
--- a/crates/shirabe/src/util/config_validator.rs
+++ b/crates/shirabe/src/util/config_validator.rs
@@ -10,7 +10,7 @@ use crate::package::loader::ValidatingArrayLoader;
 use indexmap::IndexMap;
 use serde::de::Error as _;
 use shirabe_external_packages::composer::pcre::Preg;
-use shirabe_php_shim::PhpMixed;
+use shirabe_php_shim::{PhpMixed, php_regex};
 use shirabe_spdx_licenses::SpdxLicenses;
 
 #[derive(Debug)]
@@ -123,13 +123,16 @@ impl ConfigValidator {
                         _ => false,
                     };
                     if is_deprecated {
-                        if Preg::is_match(r"{^[AL]?GPL-[123](\.[01])?\+$}i", license) {
+                        if Preg::is_match(php_regex!(r"{^[AL]?GPL-[123](\.[01])?\+$}i"), license) {
                             warnings.push(format!(
                                 "License \"{}\" is a deprecated SPDX license identifier, use \"{}-or-later\" instead",
                                 license,
                                 license.replace('+', "")
                             ));
-                        } else if Preg::is_match(r"{^[AL]?GPL-[123](\.[01])?$}i", license) {
+                        } else if Preg::is_match(
+                            php_regex!(r"{^[AL]?GPL-[123](\.[01])?$}i"),
+                            license,
+                        ) {
                             warnings.push(format!(
                                 "License \"{}\" is a deprecated SPDX license identifier, use \"{}-only\" or \"{}-or-later\" instead",
                                 license, license, license
@@ -151,10 +154,10 @@ impl ConfigValidator {
 
         if let Some(PhpMixed::String(name)) = manifest.get("name")
             && !name.is_empty()
-            && Preg::is_match(r"{[A-Z]}", name)
+            && Preg::is_match(php_regex!(r"{[A-Z]}"), name)
         {
             let suggest_name = Preg::replace(
-                r"{(?:([a-z])([A-Z])|([A-Z])([A-Z][a-z]))}",
+                php_regex!(r"{(?:([a-z])([A-Z])|([A-Z])([A-Z][a-z]))}"),
                 r"\1\3-\2\4",
                 name,
             );
@@ -228,7 +231,7 @@ impl ConfigValidator {
         packages.extend(require_dev);
         for (package, version) in &packages {
             if let PhpMixed::String(version_str) = version
-                && Preg::is_match(r"{#}", version_str)
+                && Preg::is_match(php_regex!(r"{#}"), version_str)
             {
                 warnings.push(format!(
                         "The package \"{}\" is pointing to a commit-ref, this is bad practice and can cause unforeseen issues.",
-- 
cgit v1.3.1