From e093b2be1c333e67c96aebb0a5291bea9ae3d6db Mon Sep 17 00:00:00 2001 From: nsfisis Date: Tue, 18 Aug 2026 01:57:02 +0900 Subject: refactor(preg): drop the offset argument from preg_match Every call site but one passed offset 0. The remaining one, the UTF-8 chunking loop in Application, slices the subject instead: its pattern has no anchor or lookaround, so matching a suffix is equivalent to starting the search at that offset. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/util/forgejo_url.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'crates/shirabe/src/util/forgejo_url.rs') diff --git a/crates/shirabe/src/util/forgejo_url.rs b/crates/shirabe/src/util/forgejo_url.rs index abb39d88..3aa32113 100644 --- a/crates/shirabe/src/util/forgejo_url.rs +++ b/crates/shirabe/src/util/forgejo_url.rs @@ -1,6 +1,6 @@ //! ref: composer/src/Composer/Util/ForgejoUrl.php -use shirabe_php_shim::{InvalidArgumentException, preg_match2}; +use shirabe_php_shim::{InvalidArgumentException, preg_match}; #[derive(Debug)] pub struct ForgejoUrl { @@ -36,7 +36,7 @@ impl ForgejoUrl { pub fn try_from(repo_url: Option<&str>) -> Option { let repo_url = repo_url?; - let matches = preg_match2(Self::URL_REGEX, repo_url, 0)?; + let matches = preg_match(Self::URL_REGEX, repo_url)?; let m: Vec = (0..5) .map(|i| matches.get(i).unwrap_or_default().to_string()) -- cgit v1.3.1-4-g156e