From f4cad2123b2af0de72bda4ce039e16e74f163f4e Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Sat, 8 Aug 2026 22:14:12 +0900
Subject: feat(php-shim): give ported exceptions PHP's class hierarchy

Ported exceptions were flat structs reached with `downcast_ref`, so
Composer's `catch (\RuntimeException $e)` only matched the exact leaf
type and `get_class($e)` had nothing to report. Each exception now
embeds an instance of the class it extends and travels inside an
`AnyThrowable`; `Catch::catch`/`catch_mut` walk that chain, and
`PhpClass::php_class_name` yields the PHP FQCN.

Dropping the `std::error::Error` impls from the exception types leaves
`AnyThrowable` as the only route into an `anyhow::Error`, so the walk
cannot be bypassed. A `no_exception_downcast` linter catches the
`downcast::<X>()` calls that would now silently answer `None`.

Three sites change behavior as a result: the `TransportException`
exit-code override reaches `MaxFileSizeExceededException`, the
`catch (\LogicException)` in findSimilar() reaches its subclasses, and
rendered exception titles carry the real class name rather than a
guess. `get_class_err()` is no longer a `todo!()`, which re-enables
FilesystemRepositoryTest::testCorruptedRepositoryFile.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/util/git.rs | 36 +++++++++++-------------------------
 1 file changed, 11 insertions(+), 25 deletions(-)

(limited to 'crates/shirabe/src/util/git.rs')

diff --git a/crates/shirabe/src/util/git.rs b/crates/shirabe/src/util/git.rs
index a6f8d79e..3eec0947 100644
--- a/crates/shirabe/src/util/git.rs
+++ b/crates/shirabe/src/util/git.rs
@@ -64,11 +64,7 @@ impl Git {
             );
             match io {
                 None => {
-                    return Err(RuntimeException {
-                        message: msg,
-                        code: 0,
-                    }
-                    .into());
+                    return Err(RuntimeException::new(msg).into());
                 }
                 Some(io) => {
                     io.write_error3(
@@ -215,13 +211,10 @@ impl Git {
         };
 
         if Preg::is_match(php_regex!(r"{^ssh://[^@]+@[^:]+:[^0-9]+}"), url) {
-            return Err(InvalidArgumentException {
-                message: format!(
-                    "The source URL {} is invalid, ssh URLs should have a port number after \":\".\nUse ssh://git@example.com:22/path or just git@example.com:path if you do not want to provide a password or custom port.",
-                    url
-                ),
-                code: 0,
-            }
+            return Err(InvalidArgumentException::new(format!(
+                "The source URL {} is invalid, ssh URLs should have a port number after \":\".\nUse ssh://git@example.com:22/path or just git@example.com:path if you do not want to provide a password or custom port.",
+                url
+            ))
             .into());
         }
 
@@ -1277,22 +1270,15 @@ impl Git {
             Option::<&str>::None,
         ) != 0
         {
-            return Err(RuntimeException {
-                message: Url::sanitize(format!(
-                    "Failed to clone {}, git was not found, check that it is installed and in your PATH env.\n\n{}",
-                    url,
-                    self.process.borrow().get_error_output()
-                )),
-                code: 0,
-            }
+            return Err(RuntimeException::new(Url::sanitize(format!(
+                "Failed to clone {}, git was not found, check that it is installed and in your PATH env.\n\n{}",
+                url,
+                self.process.borrow().get_error_output()
+            )))
             .into());
         }
 
-        Err(RuntimeException {
-            message: Url::sanitize(message.to_string()),
-            code: 0,
-        }
-        .into())
+        Err(RuntimeException::new(Url::sanitize(message.to_string())).into())
     }
 
     /// Retrieves the current git version.
-- 
cgit v1.3.1-4-g156e