From 716f44031a39c5e43fb441ecc470db76efc23dd4 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 14 Jun 2026 11:24:36 +0900 Subject: refactor(pcre): drop Result from Preg method return types The Preg methods panic on PCRE failure (per the file header rationale), so their anyhow::Result wrappers never carried an Err. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/util/github.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src/util/github.rs') diff --git a/crates/shirabe/src/util/github.rs b/crates/shirabe/src/util/github.rs index 1cd78c1..766d75b 100644 --- a/crates/shirabe/src/util/github.rs +++ b/crates/shirabe/src/util/github.rs @@ -333,7 +333,7 @@ impl GitHub { continue; } let mut caps: IndexMap = IndexMap::new(); - if Preg::match3(r"{\burl=(?P[^\s;]+)}", header, Some(&mut caps)).unwrap_or(false) { + if Preg::match3(r"{\burl=(?P[^\s;]+)}", header, Some(&mut caps)) { return caps.get(&CaptureKey::ByName("url".to_string())).cloned(); } } @@ -343,7 +343,7 @@ impl GitHub { pub fn is_rate_limited(&self, headers: &[String]) -> bool { for header in headers { - if Preg::is_match(r"{^x-ratelimit-remaining: *0$}i", header.trim()).unwrap_or(false) { + if Preg::is_match(r"{^x-ratelimit-remaining: *0$}i", header.trim()) { return true; } } @@ -353,7 +353,7 @@ impl GitHub { pub fn requires_sso(&self, headers: &[String]) -> bool { for header in headers { - if Preg::is_match(r"{^x-github-sso: required}i", header.trim()).unwrap_or(false) { + if Preg::is_match(r"{^x-github-sso: required}i", header.trim()) { return true; } } -- cgit v1.3.1