From 6a6ec1b8f8a5c70d21f3772ce637b763e8ab21ea Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 31 Aug 2026 00:15:52 +0900 Subject: feat(plugin): carry Http\Response across as a materialized value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A response is built for one request and the graph never retains it, so there is no entity for a handle to point at. The child holds a real instance instead, revived from the object record the wire carries, and collect() frees the copy each world holds — which is what that method is for. The value-object rule rejects the class only because collect() assigns to $this, so the category comes from an overrides.list entry. HttpDownloader::get() and copy() answer with one. Two gaps stay: decodeJson() reaches Composer\Json\JsonFile, which a guard shadows, and Composer answers a curl request with the CurlResponse subclass where this port flattens the value into a Response. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/util/http/response.rs | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'crates/shirabe/src/util/http') diff --git a/crates/shirabe/src/util/http/response.rs b/crates/shirabe/src/util/http/response.rs index 4f824baa..d505bde4 100644 --- a/crates/shirabe/src/util/http/response.rs +++ b/crates/shirabe/src/util/http/response.rs @@ -21,6 +21,13 @@ impl Response { } } + /// The url of the request this response answered. PHP keeps the whole request array in a + /// private property with no getter, and the plugin boundary codec needs the url out of it to + /// rebuild the value in the child. + pub(crate) fn request_url(&self) -> &str { + &self.url + } + pub fn get_status_code(&self) -> i64 { self.code } -- cgit v1.3.1-4-g156e