From 0b48f4a46d24248e4c012ef37d25b5963c27a78c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 23 Aug 2026 12:43:10 +0900 Subject: fix(fs): carry file_get_contents results as bytes file_get_contents() and file_get_contents_with_max_length() return Vec instead of a from_utf8_lossy'd String. Call sites whose consumer takes a &str still convert lossily and are marked TODO(bytes). file_get_contents_with_max_length() now reads at most the requested number of bytes instead of the whole file. Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/src/util/perforce.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'crates/shirabe/src/util/perforce.rs') diff --git a/crates/shirabe/src/util/perforce.rs b/crates/shirabe/src/util/perforce.rs index 295851c6..3804eed7 100644 --- a/crates/shirabe/src/util/perforce.rs +++ b/crates/shirabe/src/util/perforce.rs @@ -371,8 +371,9 @@ impl Perforce { p4_create_client_command, None, None, + // TODO(bytes): Process carries its stdin as a PhpMixed::String. file_get_contents(self.get_p4_client_spec()) - .map(PhpMixed::String) + .map(|s| PhpMixed::String(String::from_utf8_lossy(&s).into_owned())) .unwrap_or(PhpMixed::Null), None, )?; -- cgit v1.3.1-4-g156e