From efe5bdb1987411a473d4af15451a376d20928245 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Fri, 12 Jun 2026 03:19:34 +0900 Subject: refactor(php-shim): replace literal sprintf calls with format! Convert every sprintf() call with a compile-time literal format string to format!, implementing Display for PhpMixed (delegating to php_to_string) so PhpMixed values render with PHP string semantics through {}. Also merge the format!-wrapped and conditional-literal dynamic sites into single format! calls. Genuinely runtime format strings (table styles, configurable error messages, command synopsis, progress-bar modifiers, regex-built messages) still go through sprintf. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/util/remote_filesystem.rs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src/util/remote_filesystem.rs') diff --git a/crates/shirabe/src/util/remote_filesystem.rs b/crates/shirabe/src/util/remote_filesystem.rs index ff6f066..fc26775 100644 --- a/crates/shirabe/src/util/remote_filesystem.rs +++ b/crates/shirabe/src/util/remote_filesystem.rs @@ -981,12 +981,10 @@ impl RemoteFilesystem { self.io.write_error3("", true, crate::io::DEBUG); self.io.write_error3( - &sprintf( - "Following redirect (%u) %s", - &[ - PhpMixed::Int(self.redirects), - PhpMixed::String(Url::sanitize(target_url.clone())), - ], + &format!( + "Following redirect ({}) {}", + PhpMixed::Int(self.redirects), + PhpMixed::String(Url::sanitize(target_url.clone())), ), true, crate::io::DEBUG, -- cgit v1.3.1