From a73e44e327776ac4ba79737eea6b6ad00cf00da6 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 5 Jul 2026 00:30:29 +0900 Subject: fix(platform): match PHP truthy semantics for CI env checks Platform::get_env("CI").is_some()/is_none() only checked whether the variable was set, unlike PHP's (bool) Platform::getEnv('CI') which treats "" and "0" as falsy. CI="0" (used by some CI providers to explicitly disable CI mode) would previously flip behavior compared to Composer. --- crates/shirabe/src/util/stream_context_factory.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'crates/shirabe/src/util/stream_context_factory.rs') diff --git a/crates/shirabe/src/util/stream_context_factory.rs b/crates/shirabe/src/util/stream_context_factory.rs index 6a40cd0..4335777 100644 --- a/crates/shirabe/src/util/stream_context_factory.rs +++ b/crates/shirabe/src/util/stream_context_factory.rs @@ -203,7 +203,7 @@ impl StreamContextFactory { .as_deref() .map(|v| format!("; Platform-PHP {}", v)) .unwrap_or_default(), - ci = if Platform::get_env("CI").is_some() { + ci = if Platform::get_env("CI").is_some_and(|v| !v.is_empty() && v != "0") { "; CI" } else { "" -- cgit v1.3.1