From 27764ef4447a02e5c59bbcc7b4547838aae82d89 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 3 Jun 2026 21:05:15 +0900 Subject: refactor(downloader,repository,json): drop stale try/catch TODOs; fix svn getFileContent catch type Remove 17 TODO(phase-b) markers across exception-modeling sites where the existing single-Result closure+match already faithfully models the PHP try/catch (catch paths only rethrow, retry, log, or silently ignore and never yield a recoverable value, so a double Result is unnecessary). Fix SvnDriver::get_file_content to catch only RuntimeException (matching PHP's catch RuntimeException) and extract its .message instead of calling e.to_string() on the anyhow::Error, which would panic while the shim exception Display is unimplemented; other errors now propagate. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/src/util/forgejo.rs | 3 --- crates/shirabe/src/util/platform.rs | 1 - 2 files changed, 4 deletions(-) (limited to 'crates/shirabe/src/util') diff --git a/crates/shirabe/src/util/forgejo.rs b/crates/shirabe/src/util/forgejo.rs index 4db5815..232c8f3 100644 --- a/crates/shirabe/src/util/forgejo.rs +++ b/crates/shirabe/src/util/forgejo.rs @@ -122,8 +122,6 @@ impl Forgejo { ) { Ok(_) => {} Err(e) => { - // TODO(phase-b): anyhow::Error has no get_code(); HTTP status codes come from - // TransportException::get_status_code(). let code = e .downcast_ref::() .and_then(|te| te.get_status_code()) @@ -140,7 +138,6 @@ impl Forgejo { return Ok(Ok(false)); } - // TODO(phase-b): downcast anyhow::Error to TransportException for the inner Err return Err(e); } } diff --git a/crates/shirabe/src/util/platform.rs b/crates/shirabe/src/util/platform.rs index ecc362c..bb5ce1b 100644 --- a/crates/shirabe/src/util/platform.rs +++ b/crates/shirabe/src/util/platform.rs @@ -399,7 +399,6 @@ impl Platform { if php_os_family() == "Linux" { let mut process = ProcessExecutor::new(None); - // TODO(phase-b): inner Result for catch(\Exception); use anyhow::Result> let mut output = String::new(); let result: Result<()> = (|| { if process.execute_args(&["lsmod".to_string()], &mut output, ()) == 0 -- cgit v1.3.1