From 34c74255d781ad0a0bf7cc5ad4ec1761bef61e04 Mon Sep 17 00:00:00 2001
From: nsfisis <nsfisis@gmail.com>
Date: Tue, 18 Aug 2026 01:57:02 +0900
Subject: refactor(pcre): drop the two bespoke isMatch variants

is_match_named and is_match_with_indexed_captures reshaped a match into
a name-keyed map or a number-positioned vec, each allocating a String
per group up front for callers that then read one or two of them. Every
one of the eleven call sites ports a plain Preg::isMatch in PHP, so they
now call is_match3 and reach for the group they want through
get(&CaptureKey::ByIndex(N)) / get(&CaptureKey::ByName(..)), the same
way the rest of the tree already reads a match.

Falling out of that: PregNamedGroups existed only to type the first
variant; PregMatches::iter() only to build both; and PregMatches::pattern
only to give iter() the capture names. PregMatches is now a plain
wrapper over regex::Captures, so preg_replace_callback no longer clones
the resolved pattern for every match, and preg_match_map! is internal to
the shim again.

SvnDriver::get_file_content and get_change_date recover the flat
`isMatch(..) && $match[2] !== null` condition the PHP has, which the vec
shape had forced into a nested if.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 crates/shirabe/src/util/hg.rs | 54 ++++++++++++++++++++++++++++---------------
 1 file changed, 36 insertions(+), 18 deletions(-)

(limited to 'crates/shirabe/src/util')

diff --git a/crates/shirabe/src/util/hg.rs b/crates/shirabe/src/util/hg.rs
index 29d305f0..395ea6d5 100644
--- a/crates/shirabe/src/util/hg.rs
+++ b/crates/shirabe/src/util/hg.rs
@@ -5,7 +5,7 @@ use crate::io::IOInterface;
 use crate::io::IOInterfaceImmutable;
 use crate::util::ProcessExecutor;
 use crate::util::Url;
-use shirabe_pcre::Preg;
+use shirabe_pcre::{CaptureKey, Preg};
 use shirabe_php_shim::{php_regex, rawurlencode};
 use std::sync::OnceLock;
 
@@ -56,7 +56,7 @@ impl Hg {
         }
 
         // Try with the authentication information available
-        let matched = Preg::is_match_named(
+        let matched = Preg::is_match3(
             php_regex!(
                 r"{^(?P<proto>ssh|https?)://(?:(?P<user>[^:@]+)(?::(?P<pass>[^:@]+))?@)?(?P<host>[^/]+)(?P<path>/.*)?}mi"
             ),
@@ -64,30 +64,44 @@ impl Hg {
         );
 
         if let Some(matches) = matched
-            && self
-                .io
-                .has_authentication(matches.get("host").map(|s| s.as_str()).unwrap_or(""))
+            && self.io.has_authentication(
+                matches
+                    .get(&CaptureKey::ByName("host".to_string()))
+                    .unwrap_or(""),
+            )
         {
-            let authenticated_url = if matches.get("proto").map(|s| s.as_str()) == Some("ssh") {
-                let user = if let Some(u) = matches.get("user") {
+            let authenticated_url = if matches.get(&CaptureKey::ByName("proto".to_string()))
+                == Some("ssh")
+            {
+                let user = if let Some(u) = matches.get(&CaptureKey::ByName("user".to_string())) {
                     format!("{}@", rawurlencode(u))
                 } else {
                     String::new()
                 };
                 format!(
                     "{}://{}{}{}",
-                    matches.get("proto").unwrap_or(&String::new()),
+                    matches
+                        .get(&CaptureKey::ByName("proto".to_string()))
+                        .unwrap_or(""),
                     user,
-                    matches.get("host").unwrap_or(&String::new()),
-                    matches.get("path").unwrap_or(&String::new()),
+                    matches
+                        .get(&CaptureKey::ByName("host".to_string()))
+                        .unwrap_or(""),
+                    matches
+                        .get(&CaptureKey::ByName("path".to_string()))
+                        .unwrap_or(""),
                 )
             } else {
-                let auth = self
-                    .io
-                    .get_authentication(matches.get("host").map(|s| s.as_str()).unwrap_or(""));
+                let auth = self.io.get_authentication(
+                    matches
+                        .get(&CaptureKey::ByName("host".to_string()))
+                        .unwrap_or(""),
+                );
                 format!(
                     "{}://{}:{}@{}{}",
-                    matches.get("proto").unwrap_or(&String::new()),
+                    matches
+                        .get(&CaptureKey::ByName("proto".to_string()))
+                        .unwrap_or(""),
                     rawurlencode(
                         auth.get("username")
                             .and_then(|s| s.as_deref())
@@ -98,8 +112,12 @@ impl Hg {
                             .and_then(|s| s.as_deref())
                             .unwrap_or("")
                     ),
-                    matches.get("host").unwrap_or(&String::new()),
-                    matches.get("path").unwrap_or(&String::new()),
+                    matches
+                        .get(&CaptureKey::ByName("host".to_string()))
+                        .unwrap_or(""),
+                    matches
+                        .get(&CaptureKey::ByName("path".to_string()))
+                        .unwrap_or(""),
                 )
             };
 
@@ -151,12 +169,12 @@ impl Hg {
                     &mut output,
                     None,
                 ) == 0
-                    && let Some(matches) = Preg::is_match_with_indexed_captures(
+                    && let Some(matches) = Preg::is_match3(
                         php_regex!(r"/^.+? (\d+(?:\.\d+)+)(?:\+.*?)?\)?\r?\n/"),
                         &output,
                     )
                 {
-                    return matches.into_iter().nth(1).flatten();
+                    return matches.get(&CaptureKey::ByIndex(1)).map(str::to_string);
                 }
                 None
             })
-- 
cgit v1.3.1-4-g156e