From 5ab5f3b316798c1411ce8e6a7f5b091fda93589c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 22 Jun 2026 23:42:07 +0900 Subject: test: port previously-ignored Composer tests via __ test hatches Re-evaluate the reason'd #[ignore] tests under the Phase D criterion: a test is unportable ONLY if the APIs/types needed to WRITE it do not exist. A test that compiles but panics at runtime (todo!() body, a regex the regex crate cannot compile) or fails at runtime (incomplete or incorrect impl behavior) is portable -- it is written in full and marked with a reason-less #[ignore]. About 120 test functions move from reason'd #[ignore] to reason-less #[ignore] (the ported-but-not-yet-passing signal). Impl crates gain only additive __ test hatches (init_command, pool, file_downloader, package handle link setters, artifact/path repository, repository manager, svn); no existing logic changes. Tests whose required APIs genuinely do not exist (mock/reflection harness, ApplicationTester, solve() discarding SolverProblemsException, a script::Event that cannot be passed as an originating event) keep their reason'd #[ignore]. cargo check -p shirabe --tests passes. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/util/svn.rs | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'crates/shirabe/src/util') diff --git a/crates/shirabe/src/util/svn.rs b/crates/shirabe/src/util/svn.rs index 319edaf..0a3daf3 100644 --- a/crates/shirabe/src/util/svn.rs +++ b/crates/shirabe/src/util/svn.rs @@ -303,6 +303,21 @@ impl Svn { args } + /// For testing only: invoke the crate-private `get_command`. + pub fn __get_command( + &mut self, + cmd: Vec, + url: &str, + path: Option<&str>, + ) -> Vec { + self.get_command(cmd, url, path) + } + + /// For testing only: invoke the crate-private `get_credential_args`. + pub fn __get_credential_args(&mut self) -> Vec { + self.get_credential_args() + } + /// Get the password for the svn command. Can be empty. /// /// @throws \LogicException -- cgit v1.3.1