From 82cd8e8051ef791b9224916a5e2060ad38c1f82b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 19 Jul 2026 15:20:26 +0900 Subject: fix(update-command): un-ignore test_update by fixing 3 real bugs test_update was skipped for a stale reason; running it uncovered three distinct bugs it was actually catching: - ApplicationTester::run never restored SHELL_VERBOSITY after Application::configureIO mutates it, so one dataset's -vv verbosity leaked into later runs sharing the process (Symfony's tester restores it in a finally block; the port dropped that). - Installer::do_install built its RepositorySet with a hardcoded empty temporary_constraints map instead of self.temporary_constraints, so --with never actually constrained the resolver. - BumpCommand was missing a tag pair around one of its output lines. --- crates/shirabe/src/command/bump_command.rs | 2 +- crates/shirabe/src/installer.rs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) (limited to 'crates/shirabe/src') diff --git a/crates/shirabe/src/command/bump_command.rs b/crates/shirabe/src/command/bump_command.rs index 8f27fcb8..4b09f14c 100644 --- a/crates/shirabe/src/command/bump_command.rs +++ b/crates/shirabe/src/command/bump_command.rs @@ -146,7 +146,7 @@ impl BumpCommand { .is_some_and(|m| m.contains_key("type")) { io.write_error3( - "If your package is not a library, you can explicitly specify the \"type\" by using \"composer config type project\".", + "If your package is not a library, you can explicitly specify the \"type\" by using \"composer config type project\".", true, io_interface::NORMAL, ); diff --git a/crates/shirabe/src/installer.rs b/crates/shirabe/src/installer.rs index 068b85c3..6d943ea7 100644 --- a/crates/shirabe/src/installer.rs +++ b/crates/shirabe/src/installer.rs @@ -1436,14 +1436,13 @@ impl Installer { alias_normalized: alias.get("alias_normalized").cloned().unwrap_or_default(), }) .collect(); - let temporary_constraints: IndexMap = IndexMap::new(); let mut repository_set = RepositorySet::new( &minimum_stability, stability_flags, root_aliases_input, self.package.get_references().clone(), root_requires, - temporary_constraints, + self.temporary_constraints.clone(), ); repository_set.add_repository(crate::repository::RepositoryInterfaceHandle::new( RootPackageRepository::new(self.fixed_root_package.clone()), -- cgit v1.3.1