From cf0e5510dc645038b91c6fcb77ff373cb2a57d49 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 02:36:54 +0900 Subject: feat: resolve trivial todo!() placeholders Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/src/command/require_command.rs | 8 ++++++-- crates/shirabe/src/downloader/transport_exception.rs | 4 ++-- crates/shirabe/src/json/json_validation_exception.rs | 4 ++-- crates/shirabe/src/package/loader/invalid_package_exception.rs | 4 ++-- crates/shirabe/src/repository/vcs_repository.rs | 2 +- 5 files changed, 13 insertions(+), 9 deletions(-) (limited to 'crates/shirabe/src') diff --git a/crates/shirabe/src/command/require_command.rs b/crates/shirabe/src/command/require_command.rs index 31d345a..3d8331b 100644 --- a/crates/shirabe/src/command/require_command.rs +++ b/crates/shirabe/src/command/require_command.rs @@ -65,6 +65,8 @@ pub struct RequireCommand { /// contents before modification if the lock file exists lock_backup: Option, dependency_resolution_completed: bool, + repos: Option, + repository_sets: IndexMap>>, } impl Default for RequireCommand { @@ -85,6 +87,8 @@ impl RequireCommand { lock: String::new(), lock_backup: None, dependency_resolution_completed: false, + repos: None, + repository_sets: IndexMap::new(), }; command .configure() @@ -95,13 +99,13 @@ impl RequireCommand { impl PackageDiscoveryTrait for RequireCommand { fn get_repos_mut(&mut self) -> &mut Option { - todo!() + &mut self.repos } fn get_repository_sets_mut( &mut self, ) -> &mut IndexMap>> { - todo!() + &mut self.repository_sets } fn get_io(&self) -> std::rc::Rc> { diff --git a/crates/shirabe/src/downloader/transport_exception.rs b/crates/shirabe/src/downloader/transport_exception.rs index c457e1b..155a5ce 100644 --- a/crates/shirabe/src/downloader/transport_exception.rs +++ b/crates/shirabe/src/downloader/transport_exception.rs @@ -72,8 +72,8 @@ impl TransportException { } impl std::fmt::Display for TransportException { - fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { - todo!() + fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + write!(f, "{}", self.message) } } diff --git a/crates/shirabe/src/json/json_validation_exception.rs b/crates/shirabe/src/json/json_validation_exception.rs index 4549a0f..a63edda 100644 --- a/crates/shirabe/src/json/json_validation_exception.rs +++ b/crates/shirabe/src/json/json_validation_exception.rs @@ -26,8 +26,8 @@ impl JsonValidationException { } impl std::fmt::Display for JsonValidationException { - fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { - todo!() + fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + write!(f, "{}", self.inner.message) } } diff --git a/crates/shirabe/src/package/loader/invalid_package_exception.rs b/crates/shirabe/src/package/loader/invalid_package_exception.rs index 764b31f..2bd22c6 100644 --- a/crates/shirabe/src/package/loader/invalid_package_exception.rs +++ b/crates/shirabe/src/package/loader/invalid_package_exception.rs @@ -48,8 +48,8 @@ impl InvalidPackageException { } impl std::fmt::Display for InvalidPackageException { - fn fmt(&self, _f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { - todo!() + fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { + write!(f, "{}", self.inner.message) } } diff --git a/crates/shirabe/src/repository/vcs_repository.rs b/crates/shirabe/src/repository/vcs_repository.rs index de51a34..b7c0dbb 100644 --- a/crates/shirabe/src/repository/vcs_repository.rs +++ b/crates/shirabe/src/repository/vcs_repository.rs @@ -79,7 +79,7 @@ pub struct VcsRepository { impl ConfigurableRepositoryInterface for VcsRepository { fn get_repo_config(&self) -> IndexMap { - todo!() + self.repo_config.clone() } } -- cgit v1.3.1