From eab3a31c5750013c53c0eb02adc976d6757dc9f7 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 2 Jul 2026 01:32:03 +0900 Subject: chore(lint): ban std::io::Read/Write, Any, Command use imports Extends no_banned_use to cover std::any::Any, std::io::Read/Write, and std::process::Command, and teaches the linter to allow `as _` imports so trait methods can still be brought into scope without binding the banned name. Fully qualifies all existing usages across the codebase. --- crates/shirabe/src/package/archiver/archiver_interface.rs | 4 +--- crates/shirabe/src/repository/filesystem_repository.rs | 3 +-- crates/shirabe/src/util/http/curl_downloader.rs | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) (limited to 'crates/shirabe/src') diff --git a/crates/shirabe/src/package/archiver/archiver_interface.rs b/crates/shirabe/src/package/archiver/archiver_interface.rs index 54121b5..d50c96a 100644 --- a/crates/shirabe/src/package/archiver/archiver_interface.rs +++ b/crates/shirabe/src/package/archiver/archiver_interface.rs @@ -1,7 +1,5 @@ //! ref: composer/src/Composer/Package/Archiver/ArchiverInterface.php -use std::any::Any; - pub trait ArchiverInterface { fn archive( &self, @@ -15,5 +13,5 @@ pub trait ArchiverInterface { fn supports(&self, format: String, source_type: Option) -> bool; /// PHP `$archiver instanceof X` checks; allow downcasting from `dyn ArchiverInterface`. - fn as_any(&self) -> &dyn Any; + fn as_any(&self) -> &dyn std::any::Any; } diff --git a/crates/shirabe/src/repository/filesystem_repository.rs b/crates/shirabe/src/repository/filesystem_repository.rs index 0e17841..7d59bb0 100644 --- a/crates/shirabe/src/repository/filesystem_repository.rs +++ b/crates/shirabe/src/repository/filesystem_repository.rs @@ -26,7 +26,6 @@ use shirabe_php_shim::{ is_array, is_null, is_string, ksort, realpath, str_repeat, trim, usort, var_export, }; use shirabe_semver::constraint::AnyConstraint; -use std::any::Any; /// Filesystem repository. #[derive(Debug)] @@ -825,7 +824,7 @@ impl RepositoryInterface for FilesystemRepository { self.inner.get_repo_name() } - fn as_any(&self) -> &dyn Any { + fn as_any(&self) -> &dyn std::any::Any { self } diff --git a/crates/shirabe/src/util/http/curl_downloader.rs b/crates/shirabe/src/util/http/curl_downloader.rs index 0d8248b..6a6a1d6 100644 --- a/crates/shirabe/src/util/http/curl_downloader.rs +++ b/crates/shirabe/src/util/http/curl_downloader.rs @@ -632,7 +632,7 @@ impl CurlDownloader { max_file_size: Option, filename: Option<&str>, ) -> Result { - use std::io::{Read, Write}; + use std::io::{Read as _, Write as _}; let mut stream = resp; let mut written: u64 = 0; -- cgit v1.3.1