From 087020525d364e1e5bb3d9b41d020704b068c59c Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 05:21:06 +0900 Subject: fix(auditor): restore instanceof ConsoleIO semantics for BufferIO PHP's BufferIO extends ConsoleIO, so $io instanceof ConsoleIO matches it; the port models that inheritance as composition, making the plain ConsoleIO downcast reject BufferIO and throw where PHP renders tables. Also try a BufferIO downcast and unwrap its inner ConsoleIO, which unblocks the two FORMAT_TABLE cases and un-ignores test_audit. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/advisory/auditor_test.rs | 4 ---- 1 file changed, 4 deletions(-) (limited to 'crates/shirabe/tests/advisory') diff --git a/crates/shirabe/tests/advisory/auditor_test.rs b/crates/shirabe/tests/advisory/auditor_test.rs index dd904632..2b86718b 100644 --- a/crates/shirabe/tests/advisory/auditor_test.rs +++ b/crates/shirabe/tests/advisory/auditor_test.rs @@ -390,10 +390,6 @@ fn get_repo_set() -> RepositorySet { /// ref: AuditorTest::testAudit (auditProvider). #[test] -#[ignore = "all 10 cases faithfully ported; the 2 FORMAT_TABLE cases cannot run because \ - BufferIO does not downcast to ConsoleIO (PHP's `BufferIO extends ConsoleIO` is \ - modeled as composition in Rust), so the table-rendering path is unreachable and \ - the whole function stays ignored until the src supports it"] fn test_audit() { #[derive(Clone)] struct Case { -- cgit v1.3.1