From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/tests/all_functional_test.rs | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) (limited to 'crates/shirabe/tests/all_functional_test.rs') diff --git a/crates/shirabe/tests/all_functional_test.rs b/crates/shirabe/tests/all_functional_test.rs index 99a7ad0..7b3b228 100644 --- a/crates/shirabe/tests/all_functional_test.rs +++ b/crates/shirabe/tests/all_functional_test.rs @@ -3,11 +3,30 @@ // These build the composer.phar and run the .test integration fixtures by invoking the // composer binary as a subprocess; the phar build and functional-test harness are not // ported. + +// setUp only does cwd management (chdir into Fixtures/functional), which is intentionally +// not ported, so it has no portable body. + +// The chdir back to oldcwd is cwd management (not ported); the removeDirectory of testDir +// targets a path produced by the unported functional-test run. +fn tear_down() { + todo!() +} + +struct TearDown; + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + macro_rules! stub { ($name:ident) => { #[test] #[ignore = "not yet ported (builds composer.phar and runs the functional .test fixtures via the binary)"] fn $name() { + let _tear_down = TearDown; todo!() } }; -- cgit v1.3.1