From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/tests/application_test.rs | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) (limited to 'crates/shirabe/tests/application_test.rs') diff --git a/crates/shirabe/tests/application_test.rs b/crates/shirabe/tests/application_test.rs index 8251310..856c1b7 100644 --- a/crates/shirabe/tests/application_test.rs +++ b/crates/shirabe/tests/application_test.rs @@ -3,32 +3,65 @@ // These drive the console Application (doRun, getDisplay, plugin disabling, command // resolution) via ApplicationTester, none of which are ported. +use shirabe::util::platform::Platform; + +fn set_up() { + Platform::put_env("COMPOSER_DISABLE_XDEBUG_WARN", "1"); +} + +fn tear_down() { + Platform::clear_env("COMPOSER_DISABLE_XDEBUG_WARN"); +} + +struct TearDown; + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + #[test] #[ignore = "requires the console Application/ApplicationTester harness, which is not yet ported"] fn test_dev_warning() { + let _tear_down = TearDown; + set_up(); + todo!() } #[test] #[ignore = "requires the console Application/ApplicationTester harness, which is not yet ported"] fn test_dev_warning_suppressed_for_self_update() { + let _tear_down = TearDown; + set_up(); + todo!() } #[test] #[ignore = "requires the console Application/ApplicationTester harness, which is not yet ported"] fn test_process_isolation_works_multiple_times() { + let _tear_down = TearDown; + set_up(); + todo!() } #[test] #[ignore = "requires the console Application/ApplicationTester harness, which is not yet ported"] fn test_no_plugins_disables_plugins_when_script_commands_exist() { + let _tear_down = TearDown; + set_up(); + todo!() } #[test] #[ignore = "requires the console Application/ApplicationTester harness, which is not yet ported"] fn test_script_command_takes_priority_over_abbreviated_builtin_command() { + let _tear_down = TearDown; + set_up(); + todo!() } -- cgit v1.3.1