From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- crates/shirabe/tests/cache_test.rs | 54 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) (limited to 'crates/shirabe/tests/cache_test.rs') diff --git a/crates/shirabe/tests/cache_test.rs b/crates/shirabe/tests/cache_test.rs index 3849705..1e346cf 100644 --- a/crates/shirabe/tests/cache_test.rs +++ b/crates/shirabe/tests/cache_test.rs @@ -1,25 +1,79 @@ //! ref: composer/tests/Composer/Test/CacheTest.php use std::cell::RefCell; +use std::fs; use std::rc::Rc; use shirabe::cache::Cache; use shirabe::io::IOInterface; use shirabe::io::null_io::NullIO; +use shirabe::util::filesystem::Filesystem; use tempfile::TempDir; +struct SetUp { + root: TempDir, + files: Vec, + cache: Cache, +} + +fn set_up() -> SetUp { + let root = TempDir::new().unwrap(); + let mut files: Vec = Vec::new(); + let zeros = "0".repeat(1000); + + for i in 0..4 { + let path = root.path().join(format!("cached.file{}.zip", i)); + fs::write(&path, &zeros).unwrap(); + files.push(path); + } + + // The finder/filesystem/IO mocks and the Cache mock overriding getFinder are not ported. + let cache: Cache = todo!(); + + SetUp { root, files, cache } +} + +fn tear_down(root: &std::path::Path) { + if root.is_dir() { + let mut fs = Filesystem::new(None); + fs.remove_directory(root).unwrap(); + } +} + +struct TearDown { + root: std::path::PathBuf, +} + +impl TearDown { + fn new(root: std::path::PathBuf) -> Self { + TearDown { root } + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.root); + } +} + // In PHP these mock Cache::getFinder() to feed the gc() routine a controlled set of // files. getFinder is pub(crate) and cannot be overridden from a test, so the // finder-driven removal paths cannot be exercised faithfully here. #[test] #[ignore = "mocks Cache::getFinder to drive gc(); getFinder cannot be overridden from a test"] fn test_remove_outdated_files() { + let SetUp { root, files, cache } = set_up(); + let _tear_down = TearDown::new(root.path().to_path_buf()); + let _ = (&files, &cache); todo!() } #[test] #[ignore = "mocks Cache::getFinder to drive gc(); getFinder cannot be overridden from a test"] fn test_remove_files_when_cache_is_too_large() { + let SetUp { root, files, cache } = set_up(); + let _tear_down = TearDown::new(root.path().to_path_buf()); + let _ = (&files, &cache); todo!() } -- cgit v1.3.1