From 1f4addc0c016eaf0fd953fd10995d481ea7db74b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 20 Jun 2026 19:24:00 +0900 Subject: feat(console): implement doRenderThrowable exception rendering Port Symfony's Application::doRenderThrowable so command failures render the error box instead of hitting todo!(). This unblocks six CLI no-panic tests (config, depends, global, prohibits, remove, repository), whose ignore attributes are now removed. Also fill in the php-shim functions on the render path that were still todo!(): php_exception_get_code, intval, str_pad, str_split, mb_detect_encoding, mb_convert_encoding, mb_strwidth, mb_convert_variables. PHP file/line and the verbose getTrace() block have no faithful Rust equivalent; file/line use PHP's own 'n/a' fallback and the trace block is intentionally omitted. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/cli.rs | 6 ------ 1 file changed, 6 deletions(-) (limited to 'crates/shirabe/tests/cli.rs') diff --git a/crates/shirabe/tests/cli.rs b/crates/shirabe/tests/cli.rs index 5fd3980..c0fa1d9 100644 --- a/crates/shirabe/tests/cli.rs +++ b/crates/shirabe/tests/cli.rs @@ -132,18 +132,15 @@ run_no_panic_tests! { run_check_platform_reqs => "check-platform-reqs", #[ignore = "currently panics"] run_clear_cache => "clear-cache", - #[ignore = "currently panics"] run_config => "config", #[ignore = "currently panics"] run_create_project => "create-project", - #[ignore = "currently panics"] run_depends => "depends", #[ignore = "currently panics"] run_diagnose => "diagnose", run_dump_autoload => "dump-autoload", run_exec => "exec", run_fund => "fund", - #[ignore = "currently panics"] run_global => "global", #[ignore = "currently panics"] run_init => "init", @@ -151,12 +148,9 @@ run_no_panic_tests! { run_licenses => "licenses", #[ignore = "currently panics"] run_outdated => "outdated", - #[ignore = "currently panics"] run_prohibits => "prohibits", run_reinstall => "reinstall", - #[ignore = "currently panics"] run_remove => "remove", - #[ignore = "currently panics"] run_repository => "repository", #[ignore = "currently panics"] run_require => "require", -- cgit v1.3.1