From 0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:37 +0900 Subject: fix(input): thread a typed InputValue through the input layer Options and arguments were stored and passed as PhpMixed even though Symfony only ever puts a string, a bool, a list of strings or null in one. get_option already narrowed to InputOptionValue at the boundary; this widens that enum into InputValue and pushes it through InputInterface, InputOption/InputArgument defaults, the Input storage, ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option and add_argument, and the Composer-side wrappers. Two neighbouring string|int unions get types of their own: InputDefinition::{get_argument,has_argument} take an ArgumentName, and ArrayInput keys its parameters by ParameterName. has_parameter_option and get_parameter_option take the values they look for as &[&str], which is what PHP's `(array) $values` cast produced anyway. Two behaviours change along the way. Input::set_option on a negated option now negates with PHP's loose bool cast rather than treating a non-bool as false, matching `!$value`. ArrayInput::parse now resolves an integer key to an argument position instead of looking up an argument literally named "0". Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/command/audit_command_test.rs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'crates/shirabe/tests/command/audit_command_test.rs') diff --git a/crates/shirabe/tests/command/audit_command_test.rs b/crates/shirabe/tests/command/audit_command_test.rs index 617479f3..9d7a64ef 100644 --- a/crates/shirabe/tests/command/audit_command_test.rs +++ b/crates/shirabe/tests/command/audit_command_test.rs @@ -6,7 +6,8 @@ use crate::test_case::{ }; use serial_test::serial; use shirabe::package::handle::PackageInterfaceHandle; -use shirabe_php_shim::PhpMixed; +use shirabe_symfony_console::input::InputValue; +use shirabe_symfony_console::input::ParameterName; #[test] #[serial] @@ -16,7 +17,7 @@ fn test_successful_response_code_when_no_packages_are_required() { let mut app_tester = get_application_tester(); app_tester .run( - vec![(PhpMixed::from("command"), PhpMixed::from("audit"))], + vec![(ParameterName::of("command"), InputValue::from("audit"))], RunOptions::default(), ) .unwrap(); @@ -41,8 +42,8 @@ fn test_error_auditing_lock_file_when_it_is_missing() { let err = app_tester .run( vec![ - (PhpMixed::from("command"), PhpMixed::from("audit")), - (PhpMixed::from("--locked"), PhpMixed::from(true)), + (ParameterName::of("command"), InputValue::from("audit")), + (ParameterName::of("--locked"), InputValue::from(true)), ], RunOptions::default(), ) @@ -69,8 +70,8 @@ fn test_audit_package_with_no_security_vulnerabilities() { app_tester .run( vec![ - (PhpMixed::from("command"), PhpMixed::from("audit")), - (PhpMixed::from("--locked"), PhpMixed::from(true)), + (ParameterName::of("command"), InputValue::from("audit")), + (ParameterName::of("--locked"), InputValue::from(true)), ], RunOptions::default(), ) @@ -100,8 +101,8 @@ fn test_audit_package_with_no_dev_option_passed() { app_tester .run( vec![ - (PhpMixed::from("command"), PhpMixed::from("audit")), - (PhpMixed::from("--no-dev"), PhpMixed::from(true)), + (ParameterName::of("command"), InputValue::from("audit")), + (ParameterName::of("--no-dev"), InputValue::from(true)), ], RunOptions::default(), ) -- cgit v1.3.1-4-g156e