From 0800c90a7ec0bc7a3d4c13063dfe6d2298a557bc Mon Sep 17 00:00:00 2001 From: nsfisis Date: Wed, 19 Aug 2026 23:45:37 +0900 Subject: fix(input): thread a typed InputValue through the input layer Options and arguments were stored and passed as PhpMixed even though Symfony only ever puts a string, a bool, a list of strings or null in one. get_option already narrowed to InputOptionValue at the boundary; this widens that enum into InputValue and pushes it through InputInterface, InputOption/InputArgument defaults, the Input storage, ArgvInput/ArrayInput/StringInput/CompletionInput, Command::add_option and add_argument, and the Composer-side wrappers. Two neighbouring string|int unions get types of their own: InputDefinition::{get_argument,has_argument} take an ArgumentName, and ArrayInput keys its parameters by ParameterName. has_parameter_option and get_parameter_option take the values they look for as &[&str], which is what PHP's `(array) $values` cast produced anyway. Two behaviours change along the way. Input::set_option on a negated option now negates with PHP's loose bool cast rather than treating a non-bool as false, matching `!$value`. ArrayInput::parse now resolves an integer key to an argument position instead of looking up an argument literally named "0". Co-Authored-By: Claude Opus 5 (1M context) --- crates/shirabe/tests/command/exec_command_test.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/tests/command/exec_command_test.rs') diff --git a/crates/shirabe/tests/command/exec_command_test.rs b/crates/shirabe/tests/command/exec_command_test.rs index 03a2c7cf..a160664f 100644 --- a/crates/shirabe/tests/command/exec_command_test.rs +++ b/crates/shirabe/tests/command/exec_command_test.rs @@ -2,7 +2,8 @@ use crate::test_case::{RunOptions, get_application_tester, init_temp_composer}; use serial_test::serial; -use shirabe_php_shim::PhpMixed; +use shirabe_symfony_console::input::InputValue; +use shirabe_symfony_console::input::ParameterName; /// ref: ExecCommandTest::testListThrowsIfNoBinariesExist #[test] @@ -17,8 +18,8 @@ fn test_list_throws_if_no_binaries_exist() { let err = app_tester .run( vec![ - (PhpMixed::from("command"), PhpMixed::from("exec")), - (PhpMixed::from("--list"), PhpMixed::from(true)), + (ParameterName::of("command"), InputValue::from("exec")), + (ParameterName::of("--list"), InputValue::from(true)), ], RunOptions::default(), ) @@ -62,8 +63,8 @@ fn test_list() { app_tester .run( vec![ - (PhpMixed::from("command"), PhpMixed::from("exec")), - (PhpMixed::from("--list"), PhpMixed::from(true)), + (ParameterName::of("command"), InputValue::from("exec")), + (ParameterName::of("--list"), InputValue::from(true)), ], RunOptions::default(), ) -- cgit v1.3.1-4-g156e