From 72e3ec4a52e29ae01187445ba923aed3421af345 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 03:14:31 +0900 Subject: fix(validating-array-loader): un-ignore test_fund_command by fixing empty check validate_array judged emptiness via as_array(), which only matches PhpMixed::Array, so a non-empty PhpMixed::List (e.g. a funding array) was misjudged as empty and dropped, diverging from PHP's !count() check. Match both Array and List. The stale ignore reason on test_fund_command no longer applies: init_temp_composer injects packagist:false so no network is reached, and the downloader stack is reqwest-based (no curl shim todo!()). Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/command/fund_command_test.rs | 3 --- 1 file changed, 3 deletions(-) (limited to 'crates/shirabe/tests/command/fund_command_test.rs') diff --git a/crates/shirabe/tests/command/fund_command_test.rs b/crates/shirabe/tests/command/fund_command_test.rs index bbcc5892..22b9b060 100644 --- a/crates/shirabe/tests/command/fund_command_test.rs +++ b/crates/shirabe/tests/command/fund_command_test.rs @@ -72,9 +72,6 @@ fn run_fund_case( #[test] #[serial] -#[ignore = "FundCommand queries every repository (incl. the default packagist ComposerRepository) over \ - HTTP for funding metadata before falling back to locally installed data, reaching \ - shirabe-php-shim curl.rs curl_version (todo!()); this path needs real network access"] fn test_fund_command() { // 'no funding links present, locally or remotely' run_fund_case( -- cgit v1.3.1