From 82cd8e8051ef791b9224916a5e2060ad38c1f82b Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 19 Jul 2026 15:20:26 +0900 Subject: fix(update-command): un-ignore test_update by fixing 3 real bugs test_update was skipped for a stale reason; running it uncovered three distinct bugs it was actually catching: - ApplicationTester::run never restored SHELL_VERBOSITY after Application::configureIO mutates it, so one dataset's -vv verbosity leaked into later runs sharing the process (Symfony's tester restores it in a finally block; the port dropped that). - Installer::do_install built its RepositorySet with a hardcoded empty temporary_constraints map instead of self.temporary_constraints, so --with never actually constrained the resolver. - BumpCommand was missing a tag pair around one of its output lines. --- crates/shirabe/tests/command/update_command_test.rs | 3 --- 1 file changed, 3 deletions(-) (limited to 'crates/shirabe/tests/command/update_command_test.rs') diff --git a/crates/shirabe/tests/command/update_command_test.rs b/crates/shirabe/tests/command/update_command_test.rs index 866755bf..ed17d80e 100644 --- a/crates/shirabe/tests/command/update_command_test.rs +++ b/crates/shirabe/tests/command/update_command_test.rs @@ -235,7 +235,6 @@ Your requirements could not be resolved to an installable set of packages. #[test] #[serial] -#[ignore = "regex porting: a Preg pattern starting with \"^array \" fails to compile in shirabe-php-shim preg.rs (\"unterminated regex pattern\"); unrelated to InputDefinition"] fn test_update() { for (label, composer_json, command, expected, create_lock) in provide_updates() { let _tear_down = init_temp_composer(Some(&composer_json), None, None, true); @@ -260,7 +259,6 @@ fn test_update() { #[test] #[serial] -#[ignore = "resolver does not emit the temporary-update-constraint conflict; it performs the upgrade instead of reporting \"conflicts with your temporary update constraint\""] fn test_update_with_patch_only() { let composer_json = serde_json::json!({ "repositories": { "packages": { "type": "package", "package": [ @@ -604,7 +602,6 @@ fn test_no_security_blocking_allows_insecure_packages() { #[test] #[serial] -#[ignore = "solver error \"Fixed package __root__ 1.0.0+no-version-set was not added to solver pool.\" on the no-lockfile bump path (resolver pool construction)"] fn test_bump_after_update_without_lockfile() { let composer_json = serde_json::json!({ "repositories": { "packages": { "type": "package", "package": [ -- cgit v1.3.1