From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/command/clear_cache_command_test.rs | 21 +++++++++++++++++++++ crates/shirabe/tests/command/global_command_test.rs | 17 +++++++++++++++++ crates/shirabe/tests/command/init_command_test.rs | 9 +++++++++ .../shirabe/tests/command/licenses_command_test.rs | 8 ++++++++ .../tests/command/self_update_command_test.rs | 14 ++++++++++++++ 5 files changed, 69 insertions(+) (limited to 'crates/shirabe/tests/command') diff --git a/crates/shirabe/tests/command/clear_cache_command_test.rs b/crates/shirabe/tests/command/clear_cache_command_test.rs index 0e03548..29a745b 100644 --- a/crates/shirabe/tests/command/clear_cache_command_test.rs +++ b/crates/shirabe/tests/command/clear_cache_command_test.rs @@ -1,19 +1,40 @@ //! ref: composer/tests/Composer/Test/Command/ClearCacheCommandTest.php +use shirabe::util::platform::Platform; + +fn tear_down() { + // --no-cache triggers the env to change so make sure the env is cleaned up after these tests run + Platform::clear_env("COMPOSER_CACHE_DIR"); +} + +struct TearDown; + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + #[test] #[ignore = "requires the ApplicationTester/initTempComposer harness, which is not yet ported"] fn test_clear_cache_command_success() { + let _tear_down = TearDown; + todo!() } #[test] #[ignore = "requires the ApplicationTester/initTempComposer harness, which is not yet ported"] fn test_clear_cache_command_with_option_garbage_collection() { + let _tear_down = TearDown; + todo!() } #[test] #[ignore = "requires the ApplicationTester/initTempComposer harness, which is not yet ported"] fn test_clear_cache_command_with_option_no_cache() { + let _tear_down = TearDown; + todo!() } diff --git a/crates/shirabe/tests/command/global_command_test.rs b/crates/shirabe/tests/command/global_command_test.rs index 274f5cf..7877b3c 100644 --- a/crates/shirabe/tests/command/global_command_test.rs +++ b/crates/shirabe/tests/command/global_command_test.rs @@ -1,10 +1,27 @@ //! ref: composer/tests/Composer/Test/Command/GlobalCommandTest.php +use shirabe::util::platform::Platform; + +fn tear_down() { + Platform::clear_env("COMPOSER_HOME"); + Platform::clear_env("COMPOSER"); +} + +struct TearDown; + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + macro_rules! stub { ($name:ident) => { #[test] #[ignore = "requires the ApplicationTester/initTempComposer harness, which is not yet ported"] fn $name() { + let _tear_down = TearDown; + todo!() } }; diff --git a/crates/shirabe/tests/command/init_command_test.rs b/crates/shirabe/tests/command/init_command_test.rs index 69d721b..e7cda3e 100644 --- a/crates/shirabe/tests/command/init_command_test.rs +++ b/crates/shirabe/tests/command/init_command_test.rs @@ -3,11 +3,20 @@ // The author/namespace/git-config helpers are protected methods exercised via reflection // in PHP; the run cases need the ApplicationTester. Neither is available here. +use shirabe_php_shim::server_set; + +fn set_up() { + server_set("COMPOSER_DEFAULT_AUTHOR", "John Smith".to_string()); + server_set("COMPOSER_DEFAULT_EMAIL", "john@example.com".to_string()); +} + macro_rules! stub { ($name:ident) => { #[test] #[ignore = "needs the ApplicationTester harness or reflection into protected InitCommand helpers"] fn $name() { + set_up(); + todo!() } }; diff --git a/crates/shirabe/tests/command/licenses_command_test.rs b/crates/shirabe/tests/command/licenses_command_test.rs index e1dfe20..26a7520 100644 --- a/crates/shirabe/tests/command/licenses_command_test.rs +++ b/crates/shirabe/tests/command/licenses_command_test.rs @@ -1,10 +1,18 @@ //! ref: composer/tests/Composer/Test/Command/LicensesCommandTest.php +fn set_up() { + // Builds the temp project and installed.json/composer.lock fixtures via + // initTempComposer/createInstalledJson/createComposerLock, none of which are ported yet. + todo!() +} + macro_rules! stub { ($name:ident) => { #[test] #[ignore = "requires the ApplicationTester/initTempComposer harness, which is not yet ported"] fn $name() { + set_up(); + todo!() } }; diff --git a/crates/shirabe/tests/command/self_update_command_test.rs b/crates/shirabe/tests/command/self_update_command_test.rs index a4b7358..d741302 100644 --- a/crates/shirabe/tests/command/self_update_command_test.rs +++ b/crates/shirabe/tests/command/self_update_command_test.rs @@ -1,25 +1,39 @@ //! ref: composer/tests/Composer/Test/Command/SelfUpdateCommandTest.php +/// Returns the path to the copied composer.phar used by the test bodies. +fn set_up() -> String { + // Depends on initTempComposer and the composer-test.phar fixture, neither ported yet. + todo!() +} + #[test] #[ignore = "requires the ApplicationTester harness, which is not yet ported"] fn test_successful_update() { + let _phar = set_up(); + todo!() } #[test] #[ignore = "requires the ApplicationTester harness, which is not yet ported"] fn test_update_to_specific_version() { + let _phar = set_up(); + todo!() } #[test] #[ignore = "requires the ApplicationTester harness, which is not yet ported"] fn test_update_with_invalid_option_throws_exception() { + let _phar = set_up(); + todo!() } #[test] #[ignore = "requires the ApplicationTester harness, which is not yet ported"] fn test_update_to_different_channel() { + let _phar = set_up(); + todo!() } -- cgit v1.3.1