From 3b22fd4ede833b19c4113f88363021d00090d927 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 2 Aug 2026 04:53:11 +0900 Subject: fix(diagnose-command): pass the self-audit when installed.json is absent MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A native binary never ships vendor/composer/installed.json, so Composer's "non-standard Composer installation" warning fired on every diagnose run and forced exit 1. The self-audit itself stays: a Composer source snapshot is planned to be embedded together with the plugin API implementation, which will make it functional; until then the missing file reports success, marked with TODO(phase-c). Also un-ignore diagnose_command_test::test_cmd_success: the other half of its ignore reason ("requires real network access") is no blocker — the PHP original runs its live packagist/github checks unguarded too. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/command/diagnose_command_test.rs | 6 ------ 1 file changed, 6 deletions(-) (limited to 'crates/shirabe/tests/command') diff --git a/crates/shirabe/tests/command/diagnose_command_test.rs b/crates/shirabe/tests/command/diagnose_command_test.rs index 71f3aa07..d2102f95 100644 --- a/crates/shirabe/tests/command/diagnose_command_test.rs +++ b/crates/shirabe/tests/command/diagnose_command_test.rs @@ -46,12 +46,6 @@ Checking github.com rate limit: " #[test] #[serial] -#[ignore = "check_composer_audit locates Composer's own vendor/composer/installed.json through a \ - literal relative path standing in for PHP's __DIR__, so it is never found from the \ - temporary working directory this test runs in; diagnose then reports a warning and \ - exits non-zero. diagnose also checks live http/https connectivity to packagist and \ - the github.com rate limit (as the PHP original does), so the test additionally \ - requires real network access"] fn test_cmd_success() { let tear_down = init_temp_composer( Some(&serde_json::json!({ -- cgit v1.3.1