From 6f55caac4e6e55661305311174e31ec2b0e375b6 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 11 Jul 2026 20:09:27 +0900 Subject: test: update TODO reason for unported test cases No test logic changes. --- crates/shirabe/tests/command/run_script_command_test.rs | 12 ++++++++++++ crates/shirabe/tests/command/self_update_command_test.rs | 9 +++++++++ 2 files changed, 21 insertions(+) (limited to 'crates/shirabe/tests/command') diff --git a/crates/shirabe/tests/command/run_script_command_test.rs b/crates/shirabe/tests/command/run_script_command_test.rs index 75cf6786..71747a4c 100644 --- a/crates/shirabe/tests/command/run_script_command_test.rs +++ b/crates/shirabe/tests/command/run_script_command_test.rs @@ -16,6 +16,12 @@ use shirabe_php_shim::PhpMixed; Reaching it would require adding as_any to EventInterface, i.e. a src change, which is \ forbidden here -- so the faithful body is currently inexpressible and is left as todo!()."] fn test_detect_and_pass_dev_mode_to_event_and_to_dispatching() { + // TODO(phase-d): PHP asserts the ScriptEvent passed to hasEventListeners has isDevMode() == + // (dev || !no_dev), but EventInterface (src/event_dispatcher/event.rs:49) has no as_any/downcast + // seam, so a trait object cannot reach the concrete ScriptEvent::is_dev_mode + // (src/script/event.rs:51). Reaching it would require adding as_any to EventInterface, i.e. a + // src change, which is forbidden here -- so the faithful body is currently inexpressible and is + // left as todo!(). todo!() } @@ -119,11 +125,17 @@ fn test_can_define_aliases() { #[test] #[ignore = "requires writing and executing a PHP-generated Symfony Command class (file_put_contents MyCommand.php) loaded via composer autoload; fundamentally unportable, no PHP runtime command loading in shirabe"] fn test_execution_of_simple_symfony_command() { + // TODO(phase-d): requires writing and executing a PHP-generated Symfony Command class + // (file_put_contents MyCommand.php) loaded via composer autoload; fundamentally unportable, no + // PHP runtime command loading in shirabe. todo!() } #[test] #[ignore = "requires writing and executing a PHP-generated Symfony Command class (file_put_contents MyCommandWithDefinitions.php) loaded via composer autoload; fundamentally unportable, no PHP runtime command loading in shirabe"] fn test_execution_of_symfony_command_with_configuration() { + // TODO(phase-d): requires writing and executing a PHP-generated Symfony Command class + // (file_put_contents MyCommandWithDefinitions.php) loaded via composer autoload; fundamentally + // unportable, no PHP runtime command loading in shirabe. todo!() } diff --git a/crates/shirabe/tests/command/self_update_command_test.rs b/crates/shirabe/tests/command/self_update_command_test.rs index 094eb5ee..3b73adbb 100644 --- a/crates/shirabe/tests/command/self_update_command_test.rs +++ b/crates/shirabe/tests/command/self_update_command_test.rs @@ -17,6 +17,9 @@ fn set_up() -> crate::test_case::TearDown { fn test_successful_update() { let _tear_down = set_up(); + // TODO(phase-d): spawns `new Process([PHP_BINARY, $this->phar, 'self-update'])` running + // composer-test.phar over HTTP; requires Symfony Process and the composer-test.phar fixture, + // neither ported. todo!() } @@ -28,6 +31,9 @@ fn test_successful_update() { fn test_update_to_specific_version() { let _tear_down = set_up(); + // TODO(phase-d): spawns `new Process([PHP_BINARY, $this->phar, 'self-update', '2.4.0'])` + // running composer-test.phar over HTTP; requires Symfony Process and the composer-test.phar + // fixture, neither ported. todo!() } @@ -63,5 +69,8 @@ fn test_update_with_invalid_option_throws_exception() { fn test_update_to_different_channel() { let _tear_down = set_up(); + // TODO(phase-d): spawns `new Process([PHP_BINARY, $this->phar, 'self-update', $option])` + // running composer-test.phar over HTTP (data provider: --stable/--preview/--snapshot); + // requires Symfony Process and the composer-test.phar fixture, neither ported. todo!() } -- cgit v1.3.1