From c4e7f0b77938b28522ce0c94824bb53a57ba4c88 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 03:25:06 +0900 Subject: test(diagnose-command): detail ignore reasons with the actual blocker The tests fail before any network access: DiagnoseCommand::check_platform captures phpinfo() via ob_start()/ob_get_clean(), which are todo!() in shirabe-php-shim, so the command panics before producing output. Record that as the primary blocker alongside the live-network requirement. Co-Authored-By: Claude Fable 5 --- crates/shirabe/tests/command/diagnose_command_test.rs | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) (limited to 'crates/shirabe/tests/command') diff --git a/crates/shirabe/tests/command/diagnose_command_test.rs b/crates/shirabe/tests/command/diagnose_command_test.rs index 1bd0c6ac..95c713ff 100644 --- a/crates/shirabe/tests/command/diagnose_command_test.rs +++ b/crates/shirabe/tests/command/diagnose_command_test.rs @@ -7,8 +7,11 @@ use shirabe_php_shim::PhpMixed; #[test] #[serial] -#[ignore = "diagnose checks live http/https connectivity to packagist and the github.com rate \ - limit, so it requires real network access"] +#[ignore = "DiagnoseCommand::check_platform captures phpinfo() via ob_start()/ob_get_clean(), \ + which are todo!() in shirabe-php-shim (PHP output buffering and runtime introspection \ + are unmodeled), so the command panics before producing output; beyond that, diagnose \ + checks live http/https connectivity to packagist and the github.com rate limit, so the \ + test also requires real network access (as the PHP original does)"] fn test_cmd_fail() { let tear_down = init_temp_composer( Some(&serde_json::json!({ "name": "foo/bar", "description": "test pkg" })), @@ -48,8 +51,11 @@ Checking github.com rate limit: " #[test] #[serial] -#[ignore = "diagnose checks live http/https connectivity to packagist and the github.com rate \ - limit, so it requires real network access"] +#[ignore = "DiagnoseCommand::check_platform captures phpinfo() via ob_start()/ob_get_clean(), \ + which are todo!() in shirabe-php-shim (PHP output buffering and runtime introspection \ + are unmodeled), so the command panics before producing output; beyond that, diagnose \ + checks live http/https connectivity to packagist and the github.com rate limit, so the \ + test also requires real network access (as the PHP original does)"] fn test_cmd_success() { let tear_down = init_temp_composer( Some(&serde_json::json!({ -- cgit v1.3.1