From f5f429dbae0a3e2d8224c0b1e4edcef54805d286 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Thu, 25 Jun 2026 16:44:29 +0900 Subject: feat(http): reimplement CurlDownloader on reqwest; port 15 more tests Replace the libcurl-shim CurlDownloader with a reqwest+tokio implementation per the .ken sketch, resolving the construction panic that blocked command tests (mock path via __new_mock is untouched). Port remote_filesystem (7), hg/svn driver (4), zip_archiver/git_exclude_filter (4) tests. Fix hg/svn/git_exclude regex-delimiter and svn result-propagation porting bugs. Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/command/bump_command_test.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'crates/shirabe/tests/command') diff --git a/crates/shirabe/tests/command/bump_command_test.rs b/crates/shirabe/tests/command/bump_command_test.rs index 8866990..96c8baf 100644 --- a/crates/shirabe/tests/command/bump_command_test.rs +++ b/crates/shirabe/tests/command/bump_command_test.rs @@ -41,11 +41,10 @@ fn test_bump_fails_on_non_existing_composer_file() { #[test] #[serial] -#[ignore = "BumpCommand::initialize constructs a full Composer (Factory::create_http_downloader \ - -> CurlDownloader::new -> curl_multi_init), and the curl subsystem in shirabe-php-shim \ - is still todo!(). Only reachable once the HTTP/curl layer is ported. The companion \ - test_bump_fails_on_non_existing_composer_file covers the same error-output capture path \ - without reaching curl (the missing composer.json makes Composer construction a no-op)."] +#[ignore = "CurlDownloader::new no longer panics (HTTP layer is now reqwest-based), but this path \ + still reaches an unrelated todo!() in shirabe-php-shim stream_set_blocking (stream.rs), \ + which requires fcntl(2). The companion test_bump_fails_on_non_existing_composer_file \ + covers the same error-output capture path without reaching that shim."] fn test_bump_fails_on_write_error_to_composer_file() { if shirabe_php_shim::function_exists("posix_getuid") && shirabe_php_shim::posix_getuid() == 0 { // ref: $this->markTestSkipped('Cannot run as root'); -- cgit v1.3.1