From f691b864b687f251c3b266e8cff2774d730567ba Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 21:25:15 +0900 Subject: test(php-shim): un-ignore tests now unblocked by implemented shims Remove #[ignore] from tests gated solely on a shim function that is now implemented, where the test passes: - metapackage_installer::test_update (version_compare) - platform_requirement_filter_factory::test_from_bool_throws... (get_debug_type) - runtime::test_parse_extension_info (html_entity_decode/strip_tags) - package_sorter::test_sorting_does_nothing... (strnatcasecmp) - no_proxy_pattern::test_host_name/test_port (unpack/substr_count) - version_parser::test_is_upgrade (version_compare) - pool::test_what_provides_package_with_constraint - proxy_item::test_throws_on_malformed_url Update the ignore reason where the cited shim is now implemented but the test still cannot pass for a different reason: - no_proxy_pattern::test_ip_address/test_ip_range (IPv4-mapped IPv6 gap) - package_sorter::test_sorting_orders... (look-around regex) - proxy_item::test_url_formatting (parse_url host discrepancy) - json_manipulator/json_config_source/filesystem_repository stubs (test bodies are still todo!(), not yet ported) Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/config/json_config_source_test.rs | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'crates/shirabe/tests/config/json_config_source_test.rs') diff --git a/crates/shirabe/tests/config/json_config_source_test.rs b/crates/shirabe/tests/config/json_config_source_test.rs index 2d101aa..b8abf57 100644 --- a/crates/shirabe/tests/config/json_config_source_test.rs +++ b/crates/shirabe/tests/config/json_config_source_test.rs @@ -31,59 +31,57 @@ impl Drop for TearDown { } } -// JsonConfigSource edits composer.json through JsonManipulator, whose text-rewriting -// operations reach addcslashes (todo!()) in the php-shim. #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_as_list() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_repository_with_options() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_repository() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_packagist_repository_with_false_value() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_packagist() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_add_link() { let _tear_down = set_up(); todo!() } #[test] -#[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] +#[ignore = "test body not yet ported (todo!() stub)"] fn test_remove_link() { let _tear_down = set_up(); todo!() -- cgit v1.3.1