From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/config/json_config_source_test.rs | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) (limited to 'crates/shirabe/tests/config') diff --git a/crates/shirabe/tests/config/json_config_source_test.rs b/crates/shirabe/tests/config/json_config_source_test.rs index 293f32e..bab36a9 100644 --- a/crates/shirabe/tests/config/json_config_source_test.rs +++ b/crates/shirabe/tests/config/json_config_source_test.rs @@ -1,5 +1,36 @@ //! ref: composer/tests/Composer/Test/Config/JsonConfigSourceTest.php +use shirabe::util::filesystem::Filesystem; +use std::path::PathBuf; +use tempfile::TempDir; + +fn set_up() -> TearDown { + let fs = Filesystem::new(None); + // getUniqueTmpDirectory creates a fresh unique temp directory. + let working_dir = TempDir::new().unwrap(); + TearDown { fs, working_dir } +} + +struct TearDown { + fs: Filesystem, + working_dir: TempDir, +} + +impl TearDown { + fn working_dir(&self) -> PathBuf { + self.working_dir.path().to_path_buf() + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + let working_dir = self.working_dir.path(); + if working_dir.is_dir() { + self.fs.remove_directory(working_dir).unwrap(); + } + } +} + // JsonConfigSource edits composer.json through JsonManipulator, whose text-rewriting // operations reach addcslashes (todo!()) in the php-shim. macro_rules! stub { @@ -7,6 +38,7 @@ macro_rules! stub { #[test] #[ignore = "JsonConfigSource uses JsonManipulator, which reaches addcslashes (todo!()) in the php-shim"] fn $name() { + let _tear_down = set_up(); todo!() } }; -- cgit v1.3.1