From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../dependency_resolver/default_policy_test.rs | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) (limited to 'crates/shirabe/tests/dependency_resolver/default_policy_test.rs') diff --git a/crates/shirabe/tests/dependency_resolver/default_policy_test.rs b/crates/shirabe/tests/dependency_resolver/default_policy_test.rs index b852c46..979261e 100644 --- a/crates/shirabe/tests/dependency_resolver/default_policy_test.rs +++ b/crates/shirabe/tests/dependency_resolver/default_policy_test.rs @@ -1,5 +1,53 @@ //! ref: composer/tests/Composer/Test/DependencyResolver/DefaultPolicyTest.php +use indexmap::IndexMap; +use shirabe::dependency_resolver::default_policy::DefaultPolicy; +use shirabe::repository::array_repository::ArrayRepository; +use shirabe::repository::lock_array_repository::LockArrayRepository; +use shirabe::repository::repository_set::RepositorySet; +use shirabe::util::platform::Platform; + +#[allow(dead_code)] +struct Fixtures { + repository_set: RepositorySet, + repo: ArrayRepository, + repo_locked: LockArrayRepository, + policy: DefaultPolicy, +} + +fn set_up() -> Fixtures { + let repository_set = RepositorySet::new( + "dev", + IndexMap::new(), + vec![], + IndexMap::new(), + IndexMap::new(), + IndexMap::new(), + ); + let repo = ArrayRepository::new(vec![]).unwrap(); + let repo_locked = LockArrayRepository::new(vec![]).unwrap(); + + let policy = DefaultPolicy::new(false, false, None); + + Fixtures { + repository_set, + repo, + repo_locked, + policy, + } +} + +fn tear_down() { + Platform::clear_env("COMPOSER_PREFER_DEV_OVER_PRERELEASE"); +} + +struct TearDown; +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + // These build a Pool from packages and exercise DefaultPolicy::selectPreferredPackages. // Constructing the packages/constraints parses versions through a look-around regex the // regex crate cannot compile, and the setup mirrors the solver fixtures. @@ -8,6 +56,8 @@ macro_rules! stub { #[test] #[ignore = "not yet ported (DefaultPolicy over a Pool; constraint parsing uses a look-around regex)"] fn $name() { + let _tear_down = TearDown; + let _fixtures = set_up(); todo!() } }; -- cgit v1.3.1