From 0bf96f5de11555ddfdcde81c0a27869afeaf5832 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 28 Jun 2026 07:16:42 +0900 Subject: test(console): correct inaccurate test skip reasons setCatchErrors is an old-Symfony compatibility shim that exists in neither Composer's PHP class nor Shirabe, and setAutoExit(false) is the default in Shirabe, so neither is a reason a test is unportable. Drop those mentions and point the application_test ignores at the real blocker: do_run's script-command registration is still a todo!(). Co-Authored-By: Claude Opus 4.8 (1M context) --- crates/shirabe/tests/documentation_test.rs | 2 -- 1 file changed, 2 deletions(-) (limited to 'crates/shirabe/tests/documentation_test.rs') diff --git a/crates/shirabe/tests/documentation_test.rs b/crates/shirabe/tests/documentation_test.rs index 07694d8..4fe9a94 100644 --- a/crates/shirabe/tests/documentation_test.rs +++ b/crates/shirabe/tests/documentation_test.rs @@ -18,8 +18,6 @@ fn get_command_name(command: &Rc>) -> String { fn provide_command_cases() -> Vec>> { let application = ApplicationHandle::new("Composer".to_string(), "".to_string()).unwrap(); - // setAutoExit(false) is the default in Shirabe. The setCatchErrors() call is guarded by - // method_exists() in PHP and has no Rust equivalent. application.set_catch_exceptions(false); let mut description = -- cgit v1.3.1