From da751367b50ec4c680aa5f45d3ce0d192d647dbb Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 12 Jul 2026 01:28:29 +0900 Subject: test(downloader): record TODO(phase-d) reasons and port two git-downloader tests zip/git/file downloader tests that were already #[ignore]d for a documented reason lacked the required in-body // TODO(phase-d) comment; record it for each. Two git_downloader_test.rs cases, test_download_uses_various_protocols_and_sets_push_url_for_github and test_update_doesnt_throws_runtime_exception_if_git_command_fails_at_first_but_is_able_to_recover, had been left as todo!() with a TODO(phase-d) claiming ComposerMirror::process_git_url's github regex lacks PCRE delimiters and panics. That regex already has delimiters and does not panic (verified directly), and other tests in this same file already use Package::set_source_mirrors to give a real package a mirror-prefixed getSourceUrls() list, so the stated blocker no longer applies. Port both tests using that existing technique instead of recording a TODO(phase-d) for them. No other test logic changes. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe/tests/downloader/file_downloader_test.rs | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'crates/shirabe/tests/downloader/file_downloader_test.rs') diff --git a/crates/shirabe/tests/downloader/file_downloader_test.rs b/crates/shirabe/tests/downloader/file_downloader_test.rs index 2fd7d52e..e2b19958 100644 --- a/crates/shirabe/tests/downloader/file_downloader_test.rs +++ b/crates/shirabe/tests/downloader/file_downloader_test.rs @@ -185,12 +185,18 @@ fn test_download_but_file_is_unsaved() { #[test] #[ignore = "requires PHPUnit mocks of Cache::copyTo/copyFrom asserting on $cacheKey plus PreFileDownloadEvent::setProcessedUrl dispatch, which is TODO(plugin) in FileDownloader::download"] fn test_download_with_custom_processed_url() { + // TODO(phase-d): requires PHPUnit mocks of Cache::copyTo/copyFrom asserting on $cacheKey + // plus PreFileDownloadEvent::setProcessedUrl dispatch, which is TODO(plugin) in + // FileDownloader::download. todo!() } #[test] #[ignore = "requires PHPUnit mocks of Cache::copyTo/copyFrom asserting on $cacheKey plus PreFileDownloadEvent::setCustomCacheKey dispatch, which is TODO(plugin) in FileDownloader::download"] fn test_download_with_custom_cache_key() { + // TODO(phase-d): requires PHPUnit mocks of Cache::copyTo/copyFrom asserting on $cacheKey + // plus PreFileDownloadEvent::setCustomCacheKey dispatch, which is TODO(plugin) in + // FileDownloader::download. todo!() } -- cgit v1.3.1