From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/downloader/git_downloader_test.rs | 44 ++++++++++++++++++++++ 1 file changed, 44 insertions(+) (limited to 'crates/shirabe/tests/downloader/git_downloader_test.rs') diff --git a/crates/shirabe/tests/downloader/git_downloader_test.rs b/crates/shirabe/tests/downloader/git_downloader_test.rs index c332b5d..ad5e305 100644 --- a/crates/shirabe/tests/downloader/git_downloader_test.rs +++ b/crates/shirabe/tests/downloader/git_downloader_test.rs @@ -1,5 +1,46 @@ //! ref: composer/tests/Composer/Test/Downloader/GitDownloaderTest.php +use shirabe::util::filesystem::Filesystem; +use tempfile::TempDir; + +fn set_up() -> TempDir { + // skipIfNotExecutable('git') + let () = todo!(); + // initGitVersion('1.0.0') resets the Composer\Util\Git static version cache via + // reflection; the static cache is not reachable from a test here. + #[allow(unreachable_code)] + { + let _fs = Filesystem::new(None); + TempDir::new().unwrap() + } +} + +fn tear_down(working_dir: &std::path::Path) { + if working_dir.is_dir() { + let mut fs = Filesystem::new(None); + fs.remove_directory(working_dir).unwrap(); + } + // initGitVersion(false) resets the Composer\Util\Git static version cache via + // reflection; the static cache is not reachable from a test here. + todo!() +} + +struct TearDown { + working_dir: std::path::PathBuf, +} + +impl TearDown { + fn new(working_dir: std::path::PathBuf) -> Self { + TearDown { working_dir } + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.working_dir); + } +} + // These construct a GitDownloader with a mocked IO/Config and a mocked ProcessExecutor to // feed git command output; mocking is not available, and a real HttpDownloader reaches // curl_multi_init (todo!()). @@ -8,6 +49,9 @@ macro_rules! stub { #[test] #[ignore = "mocks ProcessExecutor/IO and needs an HttpDownloader (curl_multi_init todo!())"] fn $name() { + let working_dir = set_up(); + let _tear_down = TearDown::new(working_dir.path().to_path_buf()); + let _ = &working_dir; todo!() } }; -- cgit v1.3.1