From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../shirabe/tests/downloader/perforce_downloader_test.rs | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'crates/shirabe/tests/downloader/perforce_downloader_test.rs') diff --git a/crates/shirabe/tests/downloader/perforce_downloader_test.rs b/crates/shirabe/tests/downloader/perforce_downloader_test.rs index 41ced48..e0f7637 100644 --- a/crates/shirabe/tests/downloader/perforce_downloader_test.rs +++ b/crates/shirabe/tests/downloader/perforce_downloader_test.rs @@ -1,28 +1,44 @@ //! ref: composer/tests/Composer/Test/Downloader/PerforceDownloaderTest.php +use tempfile::TempDir; + +fn set_up() -> TempDir { + let test_path = TempDir::new().unwrap(); + // repoConfig/config/io/processExecutor/repository/package/downloader rely on + // ProcessExecutorMock and PHPUnit mocks of the repository and Package, which are not + // ported. + let () = todo!(); + #[allow(unreachable_code)] + test_path +} + // These mock Perforce, the repository config and a Package to drive PerforceDownloader's // initialization and install paths; mocking is not available here. #[test] #[ignore = "mocks Perforce/repository/Package; mocking is not available"] fn test_init_perforce_instantiates_a_new_perforce_object() { + let _test_path = set_up(); todo!() } #[test] #[ignore = "mocks Perforce/repository/Package; mocking is not available"] fn test_init_perforce_does_nothing_if_perforce_already_set() { + let _test_path = set_up(); todo!() } #[test] #[ignore = "mocks Perforce/repository/Package; mocking is not available"] fn test_do_install_with_tag() { + let _test_path = set_up(); todo!() } #[test] #[ignore = "mocks Perforce/repository/Package; mocking is not available"] fn test_do_install_with_no_tag() { + let _test_path = set_up(); todo!() } -- cgit v1.3.1