From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../shirabe/tests/downloader/xz_downloader_test.rs | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) (limited to 'crates/shirabe/tests/downloader/xz_downloader_test.rs') diff --git a/crates/shirabe/tests/downloader/xz_downloader_test.rs b/crates/shirabe/tests/downloader/xz_downloader_test.rs index 9650991..d01779b 100644 --- a/crates/shirabe/tests/downloader/xz_downloader_test.rs +++ b/crates/shirabe/tests/downloader/xz_downloader_test.rs @@ -1,7 +1,50 @@ //! ref: composer/tests/Composer/Test/Downloader/XzDownloaderTest.php +use shirabe::util::Platform; +use shirabe::util::filesystem::Filesystem; +use tempfile::TempDir; + +fn set_up() -> TempDir { + if Platform::is_windows() { + // markTestSkipped('Skip test on Windows') + todo!() + } + if std::mem::size_of::() == 4 { + // markTestSkipped('Skip test on 32bit') + todo!() + } + TempDir::new().unwrap() +} + +fn tear_down(test_dir: &std::path::Path) { + if Platform::is_windows() { + return; + } + let mut fs = Filesystem::new(None); + fs.remove_directory(test_dir).unwrap(); +} + +struct TearDown { + test_dir: std::path::PathBuf, +} + +impl TearDown { + fn new(test_dir: std::path::PathBuf) -> Self { + TearDown { test_dir } + } +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.test_dir); + } +} + #[test] #[ignore = "needs a real HttpDownloader/Loop and an XzDownloader download cycle; HttpDownloader construction reaches curl_multi_init (todo!()) in the php-shim"] fn test_error_messages() { + let test_dir = set_up(); + let _tear_down = TearDown::new(test_dir.path().to_path_buf()); + let _ = &test_dir; todo!() } -- cgit v1.3.1