From da751367b50ec4c680aa5f45d3ce0d192d647dbb Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 12 Jul 2026 01:28:29 +0900 Subject: test(downloader): record TODO(phase-d) reasons and port two git-downloader tests zip/git/file downloader tests that were already #[ignore]d for a documented reason lacked the required in-body // TODO(phase-d) comment; record it for each. Two git_downloader_test.rs cases, test_download_uses_various_protocols_and_sets_push_url_for_github and test_update_doesnt_throws_runtime_exception_if_git_command_fails_at_first_but_is_able_to_recover, had been left as todo!() with a TODO(phase-d) claiming ComposerMirror::process_git_url's github regex lacks PCRE delimiters and panics. That regex already has delimiters and does not panic (verified directly), and other tests in this same file already use Package::set_source_mirrors to give a real package a mirror-prefixed getSourceUrls() list, so the stated blocker no longer applies. Port both tests using that existing technique instead of recording a TODO(phase-d) for them. No other test logic changes. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe/tests/downloader/zip_downloader_test.rs | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'crates/shirabe/tests/downloader/zip_downloader_test.rs') diff --git a/crates/shirabe/tests/downloader/zip_downloader_test.rs b/crates/shirabe/tests/downloader/zip_downloader_test.rs index 0c9e7b88..b8fddf68 100644 --- a/crates/shirabe/tests/downloader/zip_downloader_test.rs +++ b/crates/shirabe/tests/downloader/zip_downloader_test.rs @@ -276,6 +276,8 @@ fn test_zip_archive_only_good() { #[test] fn test_system_unzip_only_failed() { let _ = set_up(); + // TODO(phase-d): routes through ProcessExecutor::execute_async, whose mock branch is + // todo!() (no Process mock seam exists in the external-packages crate). todo!() } @@ -283,6 +285,8 @@ fn test_system_unzip_only_failed() { #[test] fn test_system_unzip_only_good() { let _ = set_up(); + // TODO(phase-d): routes through ProcessExecutor::execute_async, whose mock branch is + // todo!() (no Process mock seam exists in the external-packages crate). todo!() } @@ -290,6 +294,8 @@ fn test_system_unzip_only_good() { #[test] fn test_non_windows_fallback_good() { let _ = set_up(); + // TODO(phase-d): routes through ProcessExecutor::execute_async, whose mock branch is + // todo!() (no Process mock seam exists in the external-packages crate). todo!() } @@ -297,5 +303,7 @@ fn test_non_windows_fallback_good() { #[test] fn test_non_windows_fallback_failed() { let _ = set_up(); + // TODO(phase-d): routes through ProcessExecutor::execute_async, whose mock branch is + // todo!() (no Process mock seam exists in the external-packages crate). todo!() } -- cgit v1.3.1