From 37ed5b8c6d4cda30e668d0221eb281431dbc8c67 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Mon, 20 Jul 2026 16:04:45 +0900 Subject: test(ignore): document root causes for unannotated #[ignore] tests 74 tests carried a bare #[ignore] with no explanation. Re-ran each: 25 now pass and had the attribute removed; the remaining 49 got a concise reason (todo!() stubs, regex-crate PCRE gaps, PhpMixed type mismatches, config bool-coercion bugs, missing skipped_load wiring in PoolBuilder, etc.) so future work can find and fix them by grep. No production code or test logic/assertions were changed. Co-Authored-By: Claude Sonnet 5 --- crates/shirabe/tests/downloader/archive_downloader_test.rs | 2 -- crates/shirabe/tests/downloader/xz_downloader_test.rs | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) (limited to 'crates/shirabe/tests/downloader') diff --git a/crates/shirabe/tests/downloader/archive_downloader_test.rs b/crates/shirabe/tests/downloader/archive_downloader_test.rs index 77569e97..d1c736ca 100644 --- a/crates/shirabe/tests/downloader/archive_downloader_test.rs +++ b/crates/shirabe/tests/downloader/archive_downloader_test.rs @@ -110,7 +110,6 @@ fn provide_urls() -> Vec<&'static str> { } #[test] -#[ignore] fn test_process_url_rewrite_dist() { let downloader = get_archive_downloader(None); @@ -148,7 +147,6 @@ fn provide_bitbucket_urls() -> Vec<(&'static str, &'static str)> { } #[test] -#[ignore] fn test_process_url_rewrite_bitbucket_dist() { let downloader = get_archive_downloader(None); diff --git a/crates/shirabe/tests/downloader/xz_downloader_test.rs b/crates/shirabe/tests/downloader/xz_downloader_test.rs index db4659f9..c1fc6bc0 100644 --- a/crates/shirabe/tests/downloader/xz_downloader_test.rs +++ b/crates/shirabe/tests/downloader/xz_downloader_test.rs @@ -63,7 +63,7 @@ fn get_config(config_options: IndexMap, use_environment: bool) } #[cfg(all(not(windows), target_pointer_width = "64"))] -#[ignore] +#[ignore = "dist_url built from file!(), which yields a workspace-relative path unlike PHP's absolute __FILE__, so the file:// URL never resolves to a real file"] #[test] fn test_error_messages() { let test_dir = set_up(); -- cgit v1.3.1