From 432472808051cb4f1bb9517b858dbc810aaa5a63 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sat, 25 Jul 2026 16:16:33 +0900 Subject: refactor: replace redundant clones with moves Co-Authored-By: Claude Opus 5 --- crates/shirabe/tests/downloader/file_downloader_test.rs | 2 +- crates/shirabe/tests/downloader/git_downloader_test.rs | 4 ++-- .../shirabe/tests/downloader/perforce_downloader_test.rs | 2 +- crates/shirabe/tests/downloader/zip_downloader_test.rs | 14 +++++++------- 4 files changed, 11 insertions(+), 11 deletions(-) (limited to 'crates/shirabe/tests/downloader') diff --git a/crates/shirabe/tests/downloader/file_downloader_test.rs b/crates/shirabe/tests/downloader/file_downloader_test.rs index 623ac34c..65dc1a51 100644 --- a/crates/shirabe/tests/downloader/file_downloader_test.rs +++ b/crates/shirabe/tests/downloader/file_downloader_test.rs @@ -348,7 +348,7 @@ fn test_downgrade_shows_appropriate_message() { }, ); - let io: std::rc::Rc> = io_mock.clone(); + let io: std::rc::Rc> = io_mock; let downloader = FileDownloader::new( io, config, diff --git a/crates/shirabe/tests/downloader/git_downloader_test.rs b/crates/shirabe/tests/downloader/git_downloader_test.rs index 748dfb14..65907567 100644 --- a/crates/shirabe/tests/downloader/git_downloader_test.rs +++ b/crates/shirabe/tests/downloader/git_downloader_test.rs @@ -986,7 +986,7 @@ fn test_downgrade_shows_appropriate_message() { .borrow_mut() .expects(vec![Expectation::text_regex("{Downgrading .*}")], false) .unwrap(); - let io = io_mock.clone() as std::rc::Rc>; + let io = io_mock as std::rc::Rc>; let mut fs = Filesystem::new(None); fs.ensure_directory_exists(&format!("{}/.git", working_dir.path().to_string_lossy())) @@ -1064,7 +1064,7 @@ fn test_not_using_downgrading_with_references() { .borrow_mut() .expects(vec![Expectation::text_regex("{Upgrading .*}")], false) .unwrap(); - let io = io_mock.clone() as std::rc::Rc>; + let io = io_mock as std::rc::Rc>; let mut fs = Filesystem::new(None); fs.ensure_directory_exists(&format!("{}/.git", working_dir.path().to_string_lossy())) diff --git a/crates/shirabe/tests/downloader/perforce_downloader_test.rs b/crates/shirabe/tests/downloader/perforce_downloader_test.rs index c657e244..b1250906 100644 --- a/crates/shirabe/tests/downloader/perforce_downloader_test.rs +++ b/crates/shirabe/tests/downloader/perforce_downloader_test.rs @@ -141,7 +141,7 @@ fn do_install_workflow(source_ref: &'static str, expected_label: Option) false, ) .unwrap(); - let io: std::rc::Rc> = io_mock.clone(); + let io: std::rc::Rc> = io_mock; let config = std::rc::Rc::new(std::cell::RefCell::new(get_config(test_path.path()))); let (process, _process_guard) = get_process_executor_mock(vec![], false, MockHandler::default()); diff --git a/crates/shirabe/tests/downloader/zip_downloader_test.rs b/crates/shirabe/tests/downloader/zip_downloader_test.rs index 8ec440d8..86f9968f 100644 --- a/crates/shirabe/tests/downloader/zip_downloader_test.rs +++ b/crates/shirabe/tests/downloader/zip_downloader_test.rs @@ -206,7 +206,7 @@ fn test_zip_archive_only_failed() { downloader.__set_zip_archive_object(Some(zip_archive)); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); let e = result.expect_err("expected RuntimeException"); assert!( @@ -232,7 +232,7 @@ fn test_zip_archive_extract_only_failed() { downloader.__set_zip_archive_object(Some(zip_archive)); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); let e = result.expect_err("expected RuntimeException"); assert!( @@ -260,7 +260,7 @@ fn test_zip_archive_only_good() { downloader.__set_zip_archive_object(Some(zip_archive)); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); result.expect("extract should succeed"); } @@ -298,7 +298,7 @@ fn test_system_unzip_only_failed() { let downloader = make_downloader_with_process(&set_up, process); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); let e = result.expect_err("expected RuntimeException"); assert!( @@ -331,7 +331,7 @@ fn test_system_unzip_only_good() { let downloader = make_downloader_with_process(&set_up, process); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); result.expect("extract should succeed"); } @@ -365,7 +365,7 @@ fn test_non_windows_fallback_good() { downloader.__set_zip_archive_object(Some(zip_archive)); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); result.expect("extract should succeed"); } @@ -399,7 +399,7 @@ fn test_non_windows_fallback_failed() { downloader.__set_zip_archive_object(Some(zip_archive)); let filename = set_up.filename.to_string_lossy().into_owned(); - let result = run(downloader.extract(set_up.package.clone(), &filename, "vendor/dir")); + let result = run(downloader.extract(set_up.package, &filename, "vendor/dir")); let e = result.expect_err("expected RuntimeException"); assert!( -- cgit v1.3.1