From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../shirabe/tests/installer/binary_installer_test.rs | 20 ++++++++++++++++++++ .../tests/installer/installation_manager_test.rs | 6 ++++++ .../tests/installer/library_installer_test.rs | 20 ++++++++++++++++++++ .../tests/installer/metapackage_installer_test.rs | 7 +++++++ .../installer/suggested_packages_reporter_test.rs | 6 ++++++ 5 files changed, 59 insertions(+) (limited to 'crates/shirabe/tests/installer') diff --git a/crates/shirabe/tests/installer/binary_installer_test.rs b/crates/shirabe/tests/installer/binary_installer_test.rs index 81df0ea..0a22243 100644 --- a/crates/shirabe/tests/installer/binary_installer_test.rs +++ b/crates/shirabe/tests/installer/binary_installer_test.rs @@ -1,5 +1,25 @@ //! ref: composer/tests/Composer/Test/Installer/BinaryInstallerTest.php +/// Creates the root/vendor/bin temp directories and a mocked IO. The temp-dir +/// helpers (`getUniqueTmpDirectory`/`ensureDirectoryExistsAndClear`) and the IO +/// mock are not available here, so this remains a stub. +fn set_up() { + todo!() +} + +/// Removes the root dir created by `set_up`, which is itself a stub. +fn tear_down() { + todo!() +} + +struct TearDown; + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + // This installs a PHP binary and then executes it via ProcessExecutor, asserting the // program's output. It needs a real PHP runtime, the binary-proxy generation, and a // mocked Package's getBinaries(), none of which are available here. diff --git a/crates/shirabe/tests/installer/installation_manager_test.rs b/crates/shirabe/tests/installer/installation_manager_test.rs index 0ec4651..58d0834 100644 --- a/crates/shirabe/tests/installer/installation_manager_test.rs +++ b/crates/shirabe/tests/installer/installation_manager_test.rs @@ -1,5 +1,11 @@ //! ref: composer/tests/Composer/Test/Installer/InstallationManagerTest.php +/// Builds mocked Loop/repository/IO. The mocks are not available here, so this +/// remains a stub. +fn set_up() { + todo!() +} + // These mock individual installers, the repository and IO to drive InstallationManager's // add/execute/install/update/uninstall logic; mocking is not available here. macro_rules! stub { diff --git a/crates/shirabe/tests/installer/library_installer_test.rs b/crates/shirabe/tests/installer/library_installer_test.rs index 4f2e33e..1262970 100644 --- a/crates/shirabe/tests/installer/library_installer_test.rs +++ b/crates/shirabe/tests/installer/library_installer_test.rs @@ -1,5 +1,25 @@ //! ref: composer/tests/Composer/Test/Installer/LibraryInstallerTest.php +/// Sets up a Composer/Config over root/vendor/bin temp dirs plus mocked +/// DownloadManager/repository/IO. The temp-dir helpers and the mocks are not +/// available here, so this remains a stub. +fn set_up() { + todo!() +} + +/// Removes the root dir created by `set_up`, which is itself a stub. +fn tear_down() { + todo!() +} + +struct TearDown; + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(); + } +} + // These construct a LibraryInstaller over a temp dir with a mocked IO/Filesystem/repository // and mocked packages to drive install/update/uninstall and path resolution. macro_rules! stub { diff --git a/crates/shirabe/tests/installer/metapackage_installer_test.rs b/crates/shirabe/tests/installer/metapackage_installer_test.rs index daf2e20..60aac92 100644 --- a/crates/shirabe/tests/installer/metapackage_installer_test.rs +++ b/crates/shirabe/tests/installer/metapackage_installer_test.rs @@ -13,6 +13,13 @@ use shirabe::repository::{InstalledArrayRepository, RepositoryInterface}; use crate::test_case::get_package; +/// Builds mocked repository/IO and a MetapackageInstaller over them. The mocks +/// are not available here; the live tests below intentionally diverge to use a +/// real InstalledArrayRepository instead, so this stub is not injected. +fn set_up() { + todo!() +} + fn run(future: F) -> F::Output { tokio::runtime::Builder::new_current_thread() .build() diff --git a/crates/shirabe/tests/installer/suggested_packages_reporter_test.rs b/crates/shirabe/tests/installer/suggested_packages_reporter_test.rs index f32b10c..e47a73a 100644 --- a/crates/shirabe/tests/installer/suggested_packages_reporter_test.rs +++ b/crates/shirabe/tests/installer/suggested_packages_reporter_test.rs @@ -1,5 +1,11 @@ //! ref: composer/tests/Composer/Test/Installer/SuggestedPackagesReporterTest.php +/// Builds an IO mock and a SuggestedPackagesReporter over it. The IO mock +/// (`getIOMock`) is not available here, so this remains a stub. +fn set_up() { + todo!() +} + // These construct a SuggestedPackagesReporter with a mocked IO and assert its accumulated // suggestions and formatted output; mocking is not available here. macro_rules! stub { -- cgit v1.3.1