From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../archiver/archivable_files_finder_test.rs | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) (limited to 'crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs') diff --git a/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs b/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs index 381c032..dcca80a 100644 --- a/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs +++ b/crates/shirabe/tests/package/archiver/archivable_files_finder_test.rs @@ -1,5 +1,29 @@ //! ref: composer/tests/Composer/Test/Package/Archiver/ArchivableFilesFinderTest.php +/// Builds a temp directory tree of fixture files under a unique tmp dir; the Filesystem and +/// getUniqueTmpDirectory infrastructure is not ported. +#[allow(dead_code)] +fn set_up() -> String { + todo!() +} + +#[allow(dead_code)] +fn tear_down(_sources: &str) { + // Removes the temp directory tree created in set_up. + todo!() +} + +#[allow(dead_code)] +struct TearDown { + sources: String, +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.sources); + } +} + // These set up a temp directory tree (including a git repo) and assert the files the finder // selects with manual/git/skip excludes; the git-backed fixture setup is not ported. macro_rules! stub { -- cgit v1.3.1