From 2b2ca914cc5f2f7fde3b6e75faabbe4913fd7264 Mon Sep 17 00:00:00 2001 From: nsfisis Date: Sun, 21 Jun 2026 12:40:10 +0900 Subject: test(tests): port setUp/tearDown as set_up/tear_down with TearDown Port PHP setUp/tearDown across the ported integration tests using same-named set_up()/tear_down() functions and a TearDown struct whose Drop runs tear_down(). Fixture-init setUp returns its fixtures; tmpdir-style setUp/tearDown carry state in TearDown fields. Parts that depend on unported infrastructure (PHPUnit mocks, Config::merge, the PHP error handler) stay todo!() and are only wired into ignored stubs to avoid breaking live tests. Also fix shirabe-php-shim putenv to handle the no-'=' form (PHP unsets the variable), which Platform::clear_env relies on for the env-clearing tearDowns. Co-Authored-By: Claude Opus 4.8 --- .../tests/package/archiver/zip_archiver_test.rs | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) (limited to 'crates/shirabe/tests/package/archiver/zip_archiver_test.rs') diff --git a/crates/shirabe/tests/package/archiver/zip_archiver_test.rs b/crates/shirabe/tests/package/archiver/zip_archiver_test.rs index 1c884d8..5f41c78 100644 --- a/crates/shirabe/tests/package/archiver/zip_archiver_test.rs +++ b/crates/shirabe/tests/package/archiver/zip_archiver_test.rs @@ -1,5 +1,30 @@ //! ref: composer/tests/Composer/Test/Package/Archiver/ZipArchiverTest.php +/// Creates the Filesystem/ProcessExecutor and a unique tmp testDir; that infrastructure is +/// not ported. Returns testDir. +#[allow(dead_code)] +fn set_up() -> String { + todo!() +} + +/// Unlinks the zip files collected in filesToCleanup, then (parent) removes testDir. +#[allow(dead_code)] +fn tear_down(_files_to_cleanup: &[String], _test_dir: &str) { + todo!() +} + +#[allow(dead_code)] +struct TearDown { + files_to_cleanup: Vec, + test_dir: String, +} + +impl Drop for TearDown { + fn drop(&mut self) { + tear_down(&self.files_to_cleanup, &self.test_dir); + } +} + // ZipArchiver::archive builds a zip via ZipArchive, which is todo!() in the php-shim. #[test] -- cgit v1.3.1